Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-827

Reading p4 annotate fails with "NumberFormatException" when customers annotate ouput does not being with <changeset>:

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 1.6.5
    • 1.5.2
    • Indexing

    Description

      If a customer p4 annotate command e.g.

      p4 annotate -c -q //depot/path/to/file 
      

      Returns something like below:

      ...
      61508: set line of code 
      
      
      62709: line of code
      <div id="random"><b>HTML:</b> 
      ....
      

      Then we will get the following error:

      2008-11-17 14:33:30,401 ERROR [btpool0-17] fisheye.app P4Cache-getBlame - Exception getting annotation for file@62709
      com.cenqua.fisheye.perforce.client.P4ClientException: java.lang.NumberFormatException:For input string: "<div id="random"><b>HTML"
      	at com.cenqua.fisheye.perforce.client.P4Client.getBlame(P4Client.java:396)
      	at com.cenqua.fisheye.perforce.P4Cache.getBlame(P4Cache.java:282)
      	at com.cenqua.crucible.revision.source.RepositorySource.getBlame(RepositorySource.java:289)
      	at com.cenqua.crucible.view.AnnotateDO.<init>(AnnotateDO.java:43)
      	at com.cenqua.crucible.tags.AnnotatorTag.doStartTag(AnnotatorTag.java:34)
      	at org.apache.jsp.tag.web.review.frxInner_tag.doTag(frxInner_tag.java:281)
      	at org.apache.jsp.WEB_002dINF.jsp.crucible.review.monolithic.displayFrxInnerDiv_jsp._jspx_meth_rev_frxInner_0(displayFrxInnerDiv_jsp.java:195)
      	at org.apache.jsp.WEB_002dINF.jsp.crucible.review.monolithic.displayFrxInnerDiv_jsp._jspx_meth_cru_asJavascriptString_1(displayFrxInnerDiv_jsp.java:162)
      	at org.apache.jsp.WEB_002dINF.jsp.crucible.review.monolithic.displayFrxInnerDiv_jsp._jspService(displayFrxInnerDiv_jsp.java:78)
      	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
      	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
      

      As fisheye is expecting everyline to start with <changelist>: where changelist is a number.

      From case [CRC-367]

      Attachments

        Activity

          People

            cmacneill Conor
            pkamal Partha
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: