Details
-
Suggestion
-
Resolution: Unresolved
-
None
Description
See attached git repository exhibiting this issues - tested on 3.4.5 stable and 3.5.0 snapshot. The problem is with the file permission change. Having binary file and new change to it that doesn't change content but only file permissions, leads to GitDiffParser to assume the file is binary, because git diff output doesn't contain line starting with "Binary file" phrase.
See:
piotrs@mbp-swiety git (master) $ git log -- chmod commit b6e6880dfdd7019c76d0def427836b2ed9244f20 Author: Piotr Święcicki <pswiecicki@atlassian.com> Date: Mon Jul 7 10:22:49 2014 +0200 removed image file commit 158063eb99683fdb932eb1528ff1fcb852a2bca6 Author: Piotr Święcicki <pswiecicki@atlassian.com> Date: Mon Jul 7 10:21:32 2014 +0200 permissions changed commit fbdc43600674af55ce612e2e847c679403f3a4e0 Author: Piotr Święcicki <pswiecicki@atlassian.com> Date: Mon Jul 7 10:20:09 2014 +0200 image file added # changeset 158063e changed only file permission, FishEye assumed it is text file piotrs@mbp-swiety git (master) $ git diff fbdc43600674af55ce612e2e847c679403f3a4e0..158063eb99683fdb932eb1528ff1fcb852a2bca6 diff --git a/chmod/icn_newerrevision.gif b/chmod/icn_newerrevision.gif old mode 100644 new mode 100755
Attachments
Issue Links
- causes
-
CRUC-6871 NullPointerException in reviews on deleted binary files, if there was property only change before deletion
- Closed