Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-2993

NullPointerException if felog does not return an output

    XMLWordPrintable

Details

    Description

      A NPE is issued if felog returns nothing for a specific revision during indexing:

      2011-03-03 11:40:15,682 DEBUG [InitialPinger1 local_main_default] fisheye.app LoggingProcessMonitor-onAfterFinished - Finished process: /usr/bin/hg --config extensions.felog=/home/fecru-2.5.1/python/hg/hgfelog/hgfelog.py --config ui.verbose=false felog 0647590e8f302498bc0197ebe82f39ac4c4e9273 -p -m  took 356ms
      2011-03-03 11:40:15,682 INFO  [InitialPinger1 local_main_default] fisheye.app LoggingProcessMonitor-onAfterFinished - Exception executing command "/usr/bin/hg --config extensions.felog=/home/fecru-2.5.1/python/hg/hgfelog/hgfelog.py --config ui.verbose=false felog 0647590e8f302498bc0197ebe82f39ac4c4e9273 -p -m " java.lang.NullPointerException
      com.atlassian.utils.process.ProcessException: java.lang.NullPointerException
      
      2011-03-03 11:40:15,682 ERROR [InitialPinger1 local_main_default] fisheye.app BaseRepositoryScanner-handleSlurpException - Problem processing revisions from repo local_main_default due to class com.cenqua.fisheye.rep.RepositoryClientException - com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS: 
      com.cenqua.fisheye.rep.RepositoryClientException: com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS: 
      	at com.atlassian.fisheye.dvcs.DvcsScanner.processRevisions(DvcsScanner.java:269)
      	at com.cenqua.fisheye.rep.BaseRepositoryScanner.slurpRepository(BaseRepositoryScanner.java:291)
      	at com.cenqua.fisheye.rep.BaseRepositoryScanner.doSlurpTransaction(BaseRepositoryScanner.java:258)
      	at com.cenqua.fisheye.rep.BaseRepositoryScanner.ping(BaseRepositoryScanner.java:190)
      	at com.cenqua.fisheye.rep.BaseRepositoryEngine.doSlurp(BaseRepositoryEngine.java:85)
      	at com.cenqua.fisheye.rep.RepositoryEngine.slurp(RepositoryEngine.java:387)
      	at com.cenqua.fisheye.rep.ping.OneOffPingRequest.doRequest(OneOffPingRequest.java:25)
      	at com.cenqua.fisheye.rep.ping.PingRequest.process(PingRequest.java:66)
      	at com.cenqua.fisheye.rep.RepositoryHandle.processPingRequests(RepositoryHandle.java:132)
      	at com.cenqua.fisheye.rep.RepositoryHandle.queuePingRequest(RepositoryHandle.java:122)
      	at com.cenqua.fisheye.rep.ping.PingRequest.run(PingRequest.java:33)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
      	at java.lang.Thread.run(Thread.java:619)
      Caused by: com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS: 
      	at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:184)
      	at com.atlassian.fisheye.hg.HgScanner.processChange(HgScanner.java:228)
      	at com.atlassian.fisheye.hg.HgScanner.slurpCommits(HgScanner.java:217)
      	at com.atlassian.fisheye.dvcs.DvcsScanner.processBranch(DvcsScanner.java:390)
      	at com.atlassian.fisheye.dvcs.DvcsScanner.processRevisions(DvcsScanner.java:230)
      	... 13 more
      Caused by: com.atlassian.utils.process.ProcessException: While executing: "/usr/bin/hg --config extensions.felog=/home/fecru-2.5.1/python/hg/hgfelog/hgfelog.py --config ui.verbose=false felog 0647590e8f302498bc0197ebe82f39ac4c4e9273 -p -m "
      	at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:227)
      	at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:219)
      	at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:182)
      	... 17 more
      Caused by: com.atlassian.utils.process.ProcessException: java.lang.NullPointerException
      	at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:268)
      	at com.atlassian.utils.process.LatchedRunnable.run(LatchedRunnable.java:25)
      	... 3 more
      Caused by: java.lang.NullPointerException
      	at com.cenqua.obfuscate.idblgdlb7._Cu.append(InfinityDB_1.0.53:1427)
      	at com.atlassian.fisheye.dvcs.db.DvcsChangeSetDAO.addCommitHash(DvcsChangeSetDAO.java:112)
      	at com.atlassian.fisheye.dvcs.db.DvcsChangeSetDAO.storeAttributes(DvcsChangeSetDAO.java:101)
      	at com.atlassian.fisheye.hg.db.HgChangeSetDAO.storeAttributes(HgChangeSetDAO.java:41)
      	at com.atlassian.fisheye.hg.db.HgChangeSetDAO.storeAttributes(HgChangeSetDAO.java:15)
      	at com.cenqua.fisheye.rep.impl.CommonChangeSetDAO.store(CommonChangeSetDAO.java:146)
      	at com.atlassian.fisheye.hg.HgScanner.processChangeSet(HgScanner.java:429)
      	at com.atlassian.fisheye.hg.HgScanner.processHgCommit(HgScanner.java:358)
      	at com.atlassian.fisheye.hg.HgScanner.access$000(HgScanner.java:60)
      	at com.atlassian.fisheye.hg.HgScanner$1.processCommit(HgScanner.java:84)
      	at com.atlassian.fisheye.hg.client.HgChangeParser.handleCommit(HgChangeParser.java:226)
      	at com.atlassian.fisheye.hg.client.HgChangeParser.doProcessInputEnd(HgChangeParser.java:239)
      	at com.atlassian.fisheye.dvcs.handler.DvcsLineOutputHandler.processInputEnd(DvcsLineOutputHandler.java:50)
      	at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:51)
      	at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:36)
      	at com.atlassian.utils.process.PluggableProcessHandler.processOutput(PluggableProcessHandler.java:34)
      	at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:265)
      	... 4 more
      

      Note this is supposed to fail (felog is expected to return something), but an explicit message (rather than a NPE) would be useful.

      Attachments

        Activity

          People

            Unassigned Unassigned
            pepoirot Pierre-Etienne Poirot (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: