Details
-
Bug
-
Resolution: Fixed
-
Medium
-
3.9.0
-
None
-
None
Description
Summary
- Symptom 1: After the upgrade, for an existing review screen, it shows the files, but when a file is clicked, it doesn't show the source for the file. Trying to summarise or close the review will also fail.
- Symptom 2: When creating a new review, the wizard does not show the screen for picking the reviewers. It skips that screen and instead creates the review in a draft mode.
Steps to Reproduce
- Create a directory in your SVN repository with name having an apostrophe.
- Add a file under that directory and checkin the directory and file into SVN.
- Create a review for this changeset
Expected Results
The Review can be edited and created successfully.
Actual Results
When creating review for a changeset, the edit review dialog doesn't show and JS errors are reported on this action:
Edit action fails with error:
URL: /foo/json/cru/edit-details 404: Not Found
The exception reported is:
2015-09-03 08:49:06,806 ERROR [qtp1855610584-6946 ] com.atlassian.plugins.rest.common.error.jersey.ThrowableExceptionMapper ThrowableExceptionMapper-toResponse - Uncaught exception thrown by REST service: 'undefined' is an invalid Review PermaId com.cenqua.crucible.model.PermaIdFormatException: 'undefined' is an invalid Review PermaId at com.cenqua.crucible.model.managers.impl.DefaultReviewManager.getReviewByPermaId(DefaultReviewManager.java:518) at com.atlassian.crucible.spi.impl.DefaultReviewService.getRequiredReview(DefaultReviewService.java:592) at com.atlassian.crucible.spi.impl.DefaultReviewService.getReviewData(DefaultReviewService.java:1132) at com.atlassian.crucible.spi.impl.DefaultReviewService.getReview(DefaultReviewService.java:1122)
Workaround
Exclude the folder paths that contain the apostrophe character.