Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-5352

this protects against the NPE but it is wrong its going to mark all 'from' lines as high. that is, it will be saying that the revision that every line of a file was added is the revision that it was deleted. the problem is not in AgeColourer, its in ...

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Duplicate
    • 2.5-M5, 2.5.0
    • None
    • None
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      Classification: Factually incorrect
      Ranking: Major
      Requires Re-Review: Yes

      Created by Nick Pellow from Geoff Crain's Crucible defect on AgeColourer.java lines 160-163 https://extranet.atlassian.com/crucible/cru/CR-FE-4687#c41164 :

      this protects against the NPE but it is wrong

      its going to mark all 'from' lines as high. that is, it will be saying that the revision that every line of a file was added is the revision that it was deleted.

      the problem is not in AgeColourer, its in diffRenderer.tag - we are passing a null colourer into the renderer

      Attachments

        Issue Links

          Activity

            People

              gcrain Geoff Crain (Inactive)
              eac-crucible-user Seb Ruiz (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: