Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-3824

ReviewerCompletedEvent not fired for last reviewer to complete

    XMLWordPrintable

Details

    Description

      From http://forums.atlassian.com/thread.jspa?messageID=257348716#257348716

      The last reviewer to complete generates an AllReviewersCompletedEvent, instead of a ReviewerCompletedEvent. The AllReviewersCompletedEvent does not contain a way of determining the originator of the event.

      Two possible solutions:
      1. The last reviewer to complete should generate both a ReviewerCompleteEvent and AllReviewersCompletedEvent. This is the most correct solution, but will cause disruption downstream for event consumers since they'll be getting two events instead of one for review completion. This does have the advantage of no API change though.

      2. Expose the originator in the AllReviewersCompletedEvent. Not as disruptive, since the number of events generated will stay the same (although the API will change).

      Attachments

        Activity

          People

            Unassigned Unassigned
            bhumphreys BrendanA
            Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: