Details
-
Bug
-
Resolution: Timed out
-
Low
-
2.3.3
-
None
-
Severity 3 - Minor
-
Description
If you upload a badly formatted patch (e.g. with leading whitespace) via REST it is accepted without issue and added to the review, but the files do not show up as revisions
Patch:
<addPatch> <patch> <![CDATA[Index: src/etc/export-input.vm =================================================================== --- src/etc/export-input.vm (revision 39619) +++ src/etc/export-input.vm (working copy) @@ -31,7 +31,7 @@ <div class="loginbox box"> <h3 style="text-transform: none">Generate a PDF export of a review</h3> <div class="welcomePane"> -<form accept-charset="UTF-8" action="/plugins/servlet/export" +<form accept-charset="UTF-8" action="$request.ContextPath/plugins/servlet/export" method="post" name="exportform"><input type="hidden" name="view" value="report" /> @@ -60,4 +60,4 @@ <div class="bottomshadow"></div> </body> -</html> \ No newline at end of file +</html> ]]> </patch> </addPatch>