Loading...

Details

Type: Bug
Resolution: Fixed
Priority: Low
Fix Version/s: 3.4
Affects Version/s: 1.4.4
Component/s: None
Labels:
- affects-server
- security

Bug Fix Policy:
View Atlassian Server bug fix policy

Description

If you have a url for Space admin :

http://server.name.com/spaces/listdecorators.action?key=BP2I

And you get the space key wrong, then rather than failing gracefully, you end up with an sitemesh decoration of an empty page....

Looking at the code, you can see why:
public String getSpaceName()

{ return action.getSpace().getName(); }

You should do a null check there....

However, thats addressing the symptom more than the cause - the action should show some kind of friendly error page rather than try and render.

Here is the stacktrace:
========================================= INFO | jvm 1 | 2005/10/01 17:41:26 INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | INFO | jvm 1 | 2005/10/01 17:41:26 | ====================
| org.apache.velocity.exception.MethodInvocationException: Invocation of method 'getSpaceName' in class com.atlassian.confluence.themes.SpaceHelper threw exception class java.lang.NullPointerException : null
at org.apache.velocity.runtime.parser.node.PropertyExecutor.execute(PropertyExecutor.java:188)
at org.apache.velocity.runtime.parser.node.ASTIdentifier.execute(ASTIdentifier.java:226)
at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:207)
at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:250)
at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:94)
at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:109)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.runtime.directive.Parse.render(Parse.java:232)
at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:153)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.Template.merge(Template.java:296)
at com.atlassian.confluence.util.VelocityUtils.getRenderedTemplateWithoutSwallowingErrors(VelocityUtils.java:47)
at com.atlassian.confluence.util.VelocityUtils.getRenderedTemplate(VelocityUtils.java:33)
at com.atlassian.confluence.setup.velocity.ApplyDecoratorDirective.render(ApplyDecoratorDirective.java:224)
at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:153)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:215)
at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:153)
at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:94)
at org.apache.velocity.runtime.parser.node.ASTElseIfStatement.render(ASTElseIfStatement.java:118)
at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:128)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.Template.merge(Template.java:296)
at com.atlassian.confluence.util.VelocityUtils.getRenderedTemplateWithoutSwallowingErrors(VelocityUtils.java:47)
at com.atlassian.confluence.util.VelocityUtils.getRenderedTemplate(VelocityUtils.java:33)
at com.atlassian.confluence.setup.velocity.ApplyDecoratorDirective.render(ApplyDecoratorDirective.java:224)
at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:153)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.Template.merge(Template.java:296)
at com.opensymphony.webwork.dispatcher.VelocityResult.doExecute(VelocityResult.java:91)
at bucket.util.profiling.ProfiledVelocityResult.doExecute(ProfiledVelocityResult.java:18)
at com.opensymphony.webwork.dispatcher.WebWorkResultSupport.execute(WebWorkResultSupport.java:116)
at com.opensymphony.xwork.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:263)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:187)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.DefaultWorkflowInterceptor.intercept(DefaultWorkflowInterceptor.java:55)
at com.atlassian.confluence.core.ConfluenceWorkflowInterceptor.intercept(ConfluenceWorkflowInterceptor.java:33)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.atlassian.confluence.core.ConfluenceValidationInterceptor.intercept(ConfluenceValidationInterceptor.java:16)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.atlassian.confluence.security.actions.PermissionCheckInterceptor.intercept(PermissionCheckInterceptor.java:40)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.atlassian.confluence.pages.actions.PageAwareInterceptor.intercept(PageAwareInterceptor.java:87)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.atlassian.confluence.core.ConfluenceAutowireInterceptor.intercept(ConfluenceAutowireInterceptor.java:25)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.atlassian.confluence.util.XWorkTransactionInterceptor.intercept(XWorkTransactionInterceptor.java:133)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterceptor.java:35)
at com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocation.java:165)
at com.opensymphony.xwork.DefaultActionProxy.execute(DefaultActionProxy.java:115)
at com.opensymphony.webwork.dispatcher.ServletDispatcher.serviceAction(ServletDispatcher.java:229)
at com.opensymphony.webwork.dispatcher.ServletDispatcher.service(ServletDispatcher.java:199)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:810)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
at com.atlassian.confluence.util.profiling.ProfilingPageFilter.parsePage(ProfilingPageFilter.java:150)
at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:168)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:181)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.johnson.filters.JohnsonFilter.doFilter(JohnsonFilter.java:96)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at org.springframework.orm.hibernate.support.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:170)
at bucket.custom.FlushingSpringSessionInViewFilter.doFilterInternal(FlushingSpringSessionInViewFilter.java:31)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:73)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.util.profiling.filters.ProfilingFilter.doFilter(ProfilingFilter.java:132)
at com.atlassian.confluence.util.error.ProfilingAndErrorFilter.doFilter(ProfilingAndErrorFilter.java:27)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.core.filters.gzip.GzipFilter.doFilter(GzipFilter.java:61)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEncodingFilter.java:36)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:793)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:702)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:571)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:644)
at java.lang.Thread.run(Thread.java:534)

NPE in SpaceHelper borks page....

Details

Description

Attachments

Activity

People

Dates