Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-40249

Listing resolved inline comments does not batch the request, leading to DBCP exhaustion

    XMLWordPrintable

Details

    Description

      NOTE: This bug report is for Confluence Server. Using Confluence Cloud? See the corresponding bug report.

      Retrieving inline comment replies (/rest/inlinecomments/1.0/comments/<comment_id>/replies) is an operation that requires two database connections.

      If a page has a sizable number of resolved inline comments (20 in my test), that each have a number of comments (5 in my test), and the user opens up the "resolved comments" display for the page, the browser will launch off an individual request for every comment. This flood of requests can cause DBCP exhaustion due to requiring 2 DB connections.

      Steps to reproduce

      1. Create a new page
      2. Add 20 inline comments to it
      3. Add 5 replies to each inline comment
      4. Resolve all inline comments
      5. Refresh the page to ensure browser doesn't have anything stored locally
      6. Click the "Resolved comments" menu item from the "..."

      Expected behaviour

      • A single request is launched to retrieve the information
      • The information is displayed

      Actual behaviour

      • Partial information is displayed (and may even look accurate, but it's incomplete)
      • Confluence locks up until the DBCP requests time out

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              hmurn metrics
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: