False alarm in the log when removing a space

Steps to reproduce

1. Create a space called test
2. Create a page called test
3. Add an attachment to the test page
4. Add the same attachment to the test page
   • Here's how it will look in filesystem:

     jsashi@localhost:~/confluenceData/confluenceData34/attachments/ver003/245/52/1802245/188/171/1671188/1736713$ ls
     1
     jsashi@localhost:~/confluenceData/confluenceData34/attachments/ver003/245/52/1802245/188/171/1671188/1736713$ ls
     1 2

     1671188 is the pageid and 1736713 is the attachment id

   • Here's how it will look in database:

     ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

     ATTACHMENTID

     TITLE

     CONTENTTYPE

     PAGEID

     CREATOR

     CREATIONDATE

     LASTMODIFIER

     LASTMODDATE

     FILESIZE

     ATTACHMENT_COMMENT

     ATTVERSION

     PREVVER

     ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

     1736713	181.jpg	image/jpeg	1671188	admin	2010-11-19 16:52:33	admin	2010-11-19 16:52:33	166253		2	NULL
     1736714	181.jpg	image/jpeg	1671188	admin	2010-11-19 16:51:34	admin	2010-11-19 16:51:34	166253		1	1736713

• Note: The latest attachment will get the same ATTACHMENTID as the folder in filesystem

1. Remove the test space
2. Space will get removed without any problem. However, the following will be shown in the log:

   2010-11-19 16:59:09,301 ERROR [http-8080-5] [pages.persistence.dao.FileSystemAttachmentDataDao] removeDataForAttachment Could not find attachments to remove at '/home/jsashi/confluenceData/confluenceData34/attachments/ver003/245/52/1802245/188/171/1671188/1736714'
   – space: 1802245 | url: /spaces/doremovespace.action | userName: admin | referer: http://localhost:8080/spaces/removespace.action?key=eeeee | action: doremovespace

Intended behaviour

It is true that the folder 1736714 does not exist in the filesystem as only the original attachmentid will be used as the folder name and all subsequent versions of the same attachment will be available as 1,2,3, etc within the original folder. However, this ERROR message in the log can be confusing to users whom might think that they have missing attachments.