Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-8986

Forwarding from unavailable page to file view doesn't encode file name properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Low
    • None
    • None
    • None
    • None

    Description

      Happened when redirected from the loading progress bar to a file view with a name like "[blah]". Resulting URL was: http://localhost:7990/bitbucket/unavailable?next=%2Fbitbucket%2Fmvc%2Fprojects%2FBLAH%2Frepos%2Fdashboards%2Fbrowse%2F%255Bbb-cloud%255D%2520Availability%2520and%2520Reliability%2520%28147242%29.json

      Doesn't seem to affect clearing of cookies, then login with next parameter.
      Repo with funny file names: https://stash.atlassian.com/projects/PUR/repos/dashboards/browse

      2016-07-06 12:04:38,544 ERROR [http-nio-7990-exec-2] @71A8ZBx724x3x0 18wu2yn 0:0:0:0:0:0:0:1 "GET /mvc/error500 HTTP/1.1" c.a.s.i.web.ErrorPageController There was an unhandled excep
      tion loading [/bitbucket/unavailable]
      java.lang.IllegalArgumentException: Illegal character in path at index 53: /bitbucket/mvc/projects/BLAH/repos/dashboards/browse/[bb-cloud] Availability and Reliability (147242).json
              at java.net.URI.create(URI.java:852) ~[na:1.8.0_60]
              at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:24) ~[na:na]
              at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:24) ~[na:na]
              at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:24) ~[na:na]
              at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:24) ~[na:na]
              at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:24) ~[na:na]
              at com.atlassian.security.auth.trustedapps.filter.TrustedApplicationsFilter.doFilter(TrustedApplicationsFilter.java:94) ~[atlassian-trusted-apps-core-4.2.0.jar:na]
              at com.atlassian.oauth.serviceprovider.internal.servlet.OAuthFilter.doFilter(OAuthFilter.java:67) ~[na:na]
              at com.atlassian.security.auth.trustedapps.filter.TrustedApplicationsFilter.doFilter(TrustedApplicationsFilter.java:94) ~[atlassian-trusted-apps-core-4.2.0.jar:na]
              at com.atlassian.oauth.serviceprovider.internal.servlet.OAuthFilter.doFilter(OAuthFilter.java:67) ~[na:na]
              at com.atlassian.core.filters.ServletContextThreadLocalFilter.doFilter(ServletContextThreadLocalFilter.java:21) ~[atlassian-core-4.6.19.jar:na]
              at com.atlassian.core.filters.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31) ~[atlassian-core-4.6.19.jar:na]
              at com.atlassian.plugin.connect.plugin.auth.user.ThreeLeggedAuthFilter.doFilter(ThreeLeggedAuthFilter.java:109) ~[na:na]
              at com.atlassian.jwt.internal.servlet.JwtAuthFilter.doFilter(JwtAuthFilter.java:32) ~[na:na]
              at com.atlassian.analytics.client.filter.DefaultAnalyticsFilter.doFilter(DefaultAnalyticsFilter.java:38) ~[na:na]
              at com.atlassian.analytics.client.filter.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:39) ~[na:na]
              at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doBeforeBeforeLoginFilters(BeforeLoginPluginAuthenticationFilter.java:87) ~[classes/:na]
              at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doFilter(BeforeLoginPluginAuthenticationFilter.java:73) ~[classes/:na]
              at com.atlassian.stash.internal.request.DefaultRequestManager.doAsRequest(DefaultRequestManager.java:86) ~[bitbucket-service-impl-4.8.0-SNAPSHOT.jar:na]
              at com.atlassian.stash.internal.hazelcast.ConfigurableWebFilter.doFilter(ConfigurableWebFilter.java:38) ~[classes/:na]
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_60]
              at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]
              ... 218 frames trimmed
      Caused by: java.net.URISyntaxException: Illegal character in path at index 53: /bitbucket/mvc/projects/BLAH/repos/dashboards/browse/[bb-cloud] Availability and Reliability (147242).j
      son
              at java.net.URI$Parser.fail(URI.java:2848) ~[na:1.8.0_60]
              at java.net.URI$Parser.checkChars(URI.java:3021) ~[na:1.8.0_60]
              at java.net.URI$Parser.parseHierarchical(URI.java:3105) ~[na:1.8.0_60]
              at java.net.URI$Parser.parse(URI.java:3063) ~[na:1.8.0_60]
              at java.net.URI.<init>(URI.java:588) ~[na:1.8.0_60]
              at java.net.URI.create(URI.java:850) ~[na:1.8.0_60]
              ... 22 common frames omitted
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            crolf Christian
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: