User gets 500 error when viewing commits on Bitbucket Server

Summary

User gets 500 error when viewing commits on Bitbucket Server

Environment

N/A

Steps to Reproduce

1. Set up Bitbucket server
2. Sync with LDAP
3. Browse with a user without an email allocated to his profile

Expected Results

• User is able to browse without issue.

Actual Results

• End user sees 500 error page
• The following is shown in the atlassian-bitbucket.log

  2016-07-07 10:37:30,533 ERROR [http-nio-7990-exec-5] @7A44Dx637x190397x0 mg8stc 10.105.138.121,10.115.121.11 "GET /mvc/error 500 HTTP/1.1" c.a.s.i.web.ErrorPageController There was an unhandled exception loading [/git/projects/AVE/repos/fhd_discover yplatform/commits/961200dd47431e8ddc0fac854f7b9175d942abea]
  org.springframework.web.util.NestedServletException: Request processing failed; nested exception is com.google.template.soy. tofu.SoyTofuException: When evaluating "requirePageData('bitbucket.page.commit', ['commit': $commit, 'watchable': $commitDis cussion, 'repository': $repository])": While computing function "requirePageData('bitbucket.page.commit', ['commit': $commit , 'watchable': $commitDiscussion, 'repository': $repository])": null
  at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:981) ~[spring-webmvc-4.2.4. RELEASE.jar:4.2.4.RELEASE]
  at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:26) ~[na:na]
  at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:26) ~[na:na]
  at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:26) ~[na:na]
  at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:26) ~[na:na]
  at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:26) ~[na:na]
  at com.atlassian.stash.internal.spring.security.StashAuthenticationFilter.doFilter(StashAuthenticationFilter.java:88 ) ~[classes/:na]
  at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doInsideSpringSecurityChain(BeforeLog inPluginAuthenticationFilter.java:109) ~[classes/:na]
  at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doFilter(BeforeLoginPluginAuthenticat ionFilter.java:75) ~[classes/:na]
  at com.atlassian.security.auth.trustedapps.filter.TrustedApplicationsFilter.doFilter(TrustedApplicationsFilter.java: 94) ~[atlassian-trusted-apps-core-4.2.0.jar:na]
  at com.atlassian.oauth.serviceprovider.internal.servlet.OAuthFilter.doFilter(OAuthFilter.java:67) ~[na:na]
  at com.atlassian.security.auth.trustedapps.filter.TrustedApplicationsFilter.doFilter(TrustedApplicationsFilter.java: 94) ~[atlassian-trusted-apps-core-4.2.0.jar:na]
  at com.atlassian.oauth.serviceprovider.internal.servlet.OAuthFilter.doFilter(OAuthFilter.java:67) ~[na:na]
  at com.atlassian.core.filters.ServletContextThreadLocalFilter.doFilter(ServletContextThreadLocalFilter.java:21) ~[at lassian-core-4.6.19.jar:na]
  at com.atlassian.core.filters.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31) ~[atlassian-core-4.6.19.jar:na ]
  at com.atlassian.plugin.connect.plugin.auth.user.ThreeLeggedAuthFilter.doFilter(ThreeLeggedAuthFilter.java:122) ~[na :na]
  at com.atlassian.plugin.connect.plugin.auth.oauth.OAuth2LOFilter.doFilter(OAuth2LOFilter.java:82) ~[na:na]
  at com.atlassian.jwt.internal.servlet.JwtAuthFilter.doFilter(JwtAuthFilter.java:32) ~[na:na]
  at com.atlassian.analytics.client.filter.DefaultAnalyticsFilter.doFilter(DefaultAnalyticsFilter.java:38) ~[na:na]
  at com.atlassian.analytics.client.filter.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:39) ~[na:na]
  at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doBeforeBeforeLoginFilters(BeforeLogi nPluginAuthenticationFilter.java:87) ~[classes/:na]
  at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doFilter(BeforeLoginPluginAuthenticat ionFilter.java:73) ~[classes/:na]
  at com.atlassian.stash.internal.request.DefaultRequestManager.doAsRequest(DefaultRequestManager.java:86) ~[bitbucket -service-impl-4.5.2.jar:na]
  at com.atlassian.stash.internal.hazelcast.ConfigurableWebFilter.doFilter(ConfigurableWebFilter.java:38) ~[classes/:n a]
  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_40]
  at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
  ... 245 frames trimmed
  Caused by: com.google.template.soy.tofu.SoyTofuException: When evaluating "requirePageData('bitbucket.page.commit', ['commit ': $commit, 'watchable': $commitDiscussion, 'repository': $repository])": While computing function "requirePageData('bitbuck et.page.commit', ['commit': $commit, 'watchable': $commitDiscussion, 'repository': $repository])": null
  at bitbucket.internal.page.commit(commit.soy:16) ~[na:na]
  at com.google.template.soy.tofu.internal.BaseTofu.renderMainHelper(BaseTofu.java:369) ~[na:na]
  at com.google.template.soy.tofu.internal.BaseTofu.renderMain(BaseTofu.java:322) ~[na:na]
  at com.google.template.soy.tofu.internal.BaseTofu.access$100(BaseTofu.java:66) ~[na:na]
  at com.google.template.soy.tofu.internal.BaseTofu$RendererImpl.render(BaseTofu.java:476) ~[na:na]
  at com.atlassian.soy.impl.DefaultSoyManager.render(DefaultSoyManager.java:133) ~[na:na]
  at com.atlassian.soy.impl.DefaultSoyTemplateRenderer.render(DefaultSoyTemplateRenderer.java:45) ~[na:na]
  at com.atlassian.stash.internal.plugin.OsgiServiceProxyFactoryImpl$DynamicServiceInvocationHandler.invoke(OsgiServic eProxyFactoryImpl.java:104) ~[bitbucket-platform-4.5.2.jar:na]
  at com.atlassian.soy.springmvc.SoyView.render(SoyView.java:50) ~[atlassian-soy-spring-mvc-support-4.2.0.jar:na]
  at com.atlassian.stash.internal.web.soy.StashSoyViewResolver$1.render(StashSoyViewResolver.java:33) ~[classes/:na]
  ... 26 common frames omitted
  Caused by: com.google.template.soy.sharedpasses.render.RenderException: When evaluating "requirePageData('bitbucket.page.com mit', ['commit': $commit, 'watchable': $commitDiscussion, 'repository': $repository])": While computing function "requirePag eData('bitbucket.page.commit', ['commit': $commit, 'watchable': $commitDiscussion, 'repository': $repository])": null
  at bitbucket.internal.page.commit(commit.soy:16) ~[na:na]
  at com.google.template.soy.sharedpasses.render.RenderVisitor.eval(RenderVisitor.java:741) ~[na:na]
  at com.google.template.soy.sharedpasses.render.RenderVisitor.visitPrintNode(RenderVisitor.java:248) ~[na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visit(AbstractSoyNodeVisitor.java:87) ~[na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visit(AbstractSoyNodeVisitor.java:56) ~[na:na]
  at com.google.template.soy.basetree.AbstractNodeVisitor.visitChildren(AbstractNodeVisitor.java:59) ~[na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visitChildren(AbstractSoyNodeVisitor.java:129) ~[na:na]
  at com.google.template.soy.sharedpasses.render.RenderVisitor.visitBlockHelper(RenderVisitor.java:702) ~[na:na]
  at com.google.template.soy.sharedpasses.render.RenderVisitor.visitTemplateNode(RenderVisitor.java:220) ~[na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visitTemplateBasicNode(AbstractSoyNodeVisitor.java:160) ~[ na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visit(AbstractSoyNodeVisitor.java:66) ~[na:na]
  at com.google.template.soy.soytree.AbstractSoyNodeVisitor.visit(AbstractSoyNodeVisitor.java:56) ~[na:na]
  at com.google.template.soy.basetree.AbstractNodeVisitor.exec(AbstractNodeVisitor.java:40) ~[na:na]
  at com.google.template.soy.tofu.internal.BaseTofu.renderMainHelper(BaseTofu.java:366) ~[na:na]
  ... 34 common frames omitted
  Caused by: com.google.template.soy.sharedpasses.render.RenderException: While computing function "requirePageData('bitbucket .page.commit', ['commit': $commit, 'watchable': $commitDiscussion, 'repository': $repository])": null
  at com.google.template.soy.sharedpasses.render.EvalVisitor.computeFunctionHelper(EvalVisitor.java:672) ~[na:na]
  at com.google.template.soy.sharedpasses.render.EvalVisitor.visitFunctionNode(EvalVisitor.java:653) ~[na:na]
  at com.google.template.soy.sharedpasses.render.EvalVisitor.visitFunctionNode(EvalVisitor.java:87) ~[na:na]
  at com.google.template.soy.exprtree.AbstractReturningExprNodeVisitor.visit(AbstractReturningExprNodeVisitor.java:118 ) ~[na:na]
  at com.google.template.soy.sharedpasses.render.EvalVisitor.visitExprRootNode(EvalVisitor.java:148) ~[na:na]
  at com.google.template.soy.sharedpasses.render.EvalVisitor.visitExprRootNode(EvalVisitor.java:87) ~[na:na]
  at com.google.template.soy.exprtree.AbstractReturningExprNodeVisitor.visit(AbstractReturningExprNodeVisitor.java:81) ~[na:na]
  at com.google.template.soy.exprtree.AbstractReturningExprNodeVisitor.visit(AbstractReturningExprNodeVisitor.java:73) ~[na:na]
  at com.google.template.soy.basetree.AbstractReturningNodeVisitor.exec(AbstractReturningNodeVisitor.java:43) ~[na:na]
  at com.google.template.soy.sharedpasses.render.RenderVisitor.eval(RenderVisitor.java:739) ~[na:na]
  ... 46 common frames omitted
  Caused by: java.lang.NullPointerException: null
  at com.atlassian.stash.internal.web.fragments.IsWatchingContextProvider.getContextMap(IsWatchingContextProvider.java :47) ~[classes/:na]
  at com.atlassian.stash.internal.plugin.web.fragments.RequestCacheClientPageDataHandler.getPageData(RequestCacheClien tPageDataHandler.java:50) ~[bitbucket-platform-4.5.2.jar:na]
  at com.atlassian.stash.internal.plugin.web.fragments.RequestCacheClientPageDataHandler.requirePageData(RequestCacheC lientPageDataHandler.java:78) ~[bitbucket-platform-4.5.2.jar:na]
  at com.atlassian.stash.internal.plugin.OsgiSafeProxyProvider$1.invoke(OsgiSafeProxyProvider.java:93) ~[bitbucket-pla tform-4.5.2.jar:na]
  at com.atlassian.stash.internal.web.soy.functions.pagedata.RequirePageDataFunction.apply(RequirePageDataFunction.jav a:39) ~[classes/:na]
  at com.atlassian.stash.internal.web.soy.functions.pagedata.RequirePageDataFunction.apply(RequirePageDataFunction.jav a:16) ~[classes/:na]
  at com.atlassian.soy.impl.modules.SoyJavaFunctionAdapter.computeForJava(SoyJavaFunctionAdapter.java:34) ~[na:na]
  at com.google.template.soy.sharedpasses.render.EvalVisitor.computeFunctionHelper(EvalVisitor.java:670) ~[na:na]
  ... 55 common frames omitted
  

Workaround

Assign an email address to the user.