Description
In 3.0 the artifacts got removed from the buildDefinition into their own table.
In several upgrade tasks we get that buildDefinition out of the database, then convert to objects, then reconvert back into xml. In this conversion process the artifacts are not saved (because the BD converter doesn't convert them anymore).
Upgrade Tasks That Open then re-save the build Cofiguration
UT1702 - web repositories
UT2025 - build/chain conversion
UT2032 - change of dep provider id to be plan key
UT2033 - migration of maven2 dependency config out of builder config into custom config
UT2204 - artifact conversion
UT2405 - task conversion
Option 1: fix all the above upgrade tasks so they deal directly with the xml, rather than converting to an object
Option 2: put the artifacts conversion code back into the BuildDefinition Converter
Option 3: Fix Artifacts upgrade task to be priority upgrade task, and make it read the xml directly from the db. (it can not load the plan because we might have null columns etc.)
Chai decided option 3 is the way to go. We also need to check the rest of our upgrade tasks to make sure there are not other significant places