Medium Some BuildStrategy like Manual simply catches RepostoryExceptions, logs it and keeps going. It means that if the CVS repo is down, then the user never really know about it. This is obviously not good, we need to at least log it to the UI and cancel the build.
Currently logs something like
2007-01-10 18:44:03,141 ERROR [BAM::BuildChangeDetector] [CVSRepository] Could not obtain source code from CVS build "JIRA Plugins Unit Tests - RPC Plugin". org.netbeans.lib.cvsclient.connection.AuthenticationException: at com.atlassian.bamboo.repository.cvsimpl.ExtConnection.openConnection(ExtConnection.java:170) at com.atlassian.bamboo.repository.cvsimpl.ExtConnection.open(ExtConnection.java:48) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.openConnectionToCvs(CVSRepository.java:851) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.getChangesFromCommand(CVSRepository.java:405) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.updateLatestVersionOfModule(CVSRepository.java:386) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.getFilesSinceLastChange(CVSRepository.java:350) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.collectModuleChanges(CVSRepository.java:210) at com.atlassian.bamboo.repository.cvsimpl.CVSRepository.getChangesSinceLastBuild(CVSRepository.java:146) at com.atlassian.bamboo.build.strategy.AbstractBuildStrategy.populateChangeList(AbstractBuildStrategy.java:92) at com.atlassian.bamboo.build.strategy.ManualBuild.requiresBuild(ManualBuild.java:42) at com.atlassian.bamboo.build.DefaultBuildChangeDetector.checkIfBuildNeedsBuilding(DefaultBuildChangeDetector.java:166) at com.atlassian.bamboo.build.DefaultBuildChangeDetector.doTask(DefaultBuildChangeDetector.java:114) at com.atlassian.bamboo.build.DefaultBuildChangeDetector.run(DefaultBuildChangeDetector.java:77) at java.lang.Thread.run(Thread.java:595) Caused by: com.jcraft.jsch.JSchException: java.net.ConnectException: Connection timed out at com.jcraft.jsch.Util.createSocket(Util.java:256) at com.jcraft.jsch.Session.connect(Session.java:184) at com.jcraft.jsch.Session.connect(Session.java:148) at com.atlassian.bamboo.repository.cvsimpl.ExtConnection.openConnection(ExtConnection.java:154) ... 13 more Caused by: java.net.ConnectException: Connection timed out at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333) at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:195) at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:182) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366) at java.net.Socket.connect(Socket.java:516) at java.net.Socket.connect(Socket.java:466) at java.net.Socket.<init>(Socket.java:366) at java.net.Socket.<init>(Socket.java:179) at com.jcraft.jsch.Util.createSocket(Util.java:250) ... 16 more 2007-01-10 18:44:03,142 ERROR [BAM::BuildChangeDetector] [ManualBuild] com.atlassian.bamboo.repository.RepositoryException: Cannot open connection
