Details
-
Bug
-
Resolution: Fixed
-
Medium
-
2.0.3
-
None
Description
Perforce repository uses the StringEncrypter in a non Thread safe way which could lead to errors like:
INFO | jvm 1 | 2008/05/28 16:45:12 | 2008-05-28 16:45:12,694 WARN [pool-18-thread-1] [PerforceRepository] Could not decrypt password INFO | jvm 1 | 2008/05/28 16:45:12 | com.atlassian.bamboo.security.EncryptionException: Failed to decrypt. INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.security.StringEncrypter.decrypt(StringEncrypter.java:78) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.repository.perforce.PerforceRepository.decryptPassword(PerforceRepository.java:876) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.repository.perforce.PerforceRepository.getPerforceDepot(PerforceRepository.java:235) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.repository.perforce.PerforceRepository.collectChangesSinceLastBuild(PerforceRepository.java:120) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.v2.trigger.DefaultChangeDetectionManager.collectChangesSinceLastBuild(DefaultChangeDetectionManager.java:89) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.v2.trigger.ChangeDetectionListenerAction.process(ChangeDetectionListenerAction.java:63) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.build.DefaultBuildExecutionManager.tryToDetectAndBuild(DefaultBuildExecutionManager.java:86) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.v2.trigger.ChangeDetectionListener.handleEvent(ChangeDetectionListener.java:41) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.event.DefaultEventManager$2.run(DefaultEventManager.java:202) INFO | jvm 1 | 2008/05/28 16:45:12 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650) INFO | jvm 1 | 2008/05/28 16:45:12 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$1.run(NamedThreadFactory.java:32) INFO | jvm 1 | 2008/05/28 16:45:12 | at edu.emory.mathcs.backport.java.util.concurrent.helpers.ThreadHelpers$1.run(ThreadHelpers.java:34) INFO | jvm 1 | 2008/05/28 16:45:12 | at java.lang.Thread.run(Thread.java:595) INFO | jvm 1 | 2008/05/28 16:45:12 | Caused by: java.lang.IllegalStateException: Cipher not initialized INFO | jvm 1 | 2008/05/28 16:45:12 | at javax.crypto.Cipher.c(DashoA12275) INFO | jvm 1 | 2008/05/28 16:45:12 | at javax.crypto.Cipher.doFinal(DashoA12275) INFO | jvm 1 | 2008/05/28 16:45:12 | at com.atlassian.bamboo.security.StringEncrypter.decrypt(StringEncrypter.java:74) INFO | jvm 1 | 2008/05/28 16:45:12 | ... 13 more
as well as errors further downstream