[#BAM-1046] Valid cron expression not really valid

Bamboo

Valid cron expression not really valid

Created: 19/Mar/07 06:10 PM Updated: 29/May/07 12:15 AM

Component/s:

Build Triggers

Affects Version/s:

1.0.2

Fix Version/s:

1.1.2

Time Tracking:

Not Specified

Environment:

Linux, Standalone Bamboo 1.0.2

Issue Links:

Reference

This issue relates to:

~~BAM-1260~~ Cron triggers that specify multiples (entries with commas) get interpreted as arrays of Strings

Internal Priority:	4. Low
Participants:	Brydie McCoy [Atlassian], Edwin Wong [Atlassian], Mark Chaimungkalanont [Atlassian] and Mark Gaylard
Since last comment:	1 year, 14 weeks, 3 days ago
Internal Work Bucket:	Confirmed
Number of comments:	1
Labels:

Description

« Hide

When specifying a cron trigger, I used

0 0 20 * * MON-THU

It appeared to save ok, but when it didn't run the build I checked the bamboo.log file and found

2007-03-20 09:56:22,576 ERROR [SocketListener0-7] [CronTriggerBuildStrategy] java.lang.UnsupportedOperationException: Support for specifying both a day-of-week AND a day-of-month parameter is not implemented.
java.lang.UnsupportedOperationException: Support for specifying both a day-of-week AND a day-of-month parameter is not implemented.
at org.quartz.CronExpression.getTimeAfter(CronExpression.java:1234)
at org.quartz.CronTrigger.getTimeAfter(CronTrigger.java:857)
at org.quartz.CronTrigger.getFireTimeAfter(CronTrigger.java:587)
at org.quartz.CronTrigger.computeFirstFireTime(CronTrigger.java:836)
at org.quartz.core.QuartzScheduler.scheduleJob(QuartzScheduler.java:606)
at org.quartz.impl.StdScheduler.scheduleJob(StdScheduler.java:238)
at com.atlassian.bamboo.build.strategy.CronTriggerBuildStrategy.initialiseJob(CronTriggerBuildStrategy.java:100)
at com.atlassian.bamboo.build.HibernateBuildManager.createSchedulingJobs(HibernateBuildManager.java:384)
at com.atlassian.bamboo.build.HibernateBuildManager.saveBuildConfig(HibernateBuildManager.java:205)
<snip>

Changing the cron expression to

0 0 20 ? * MON-THU

worked ok. The first style is a valid cron expression (it came out of an existing crontab file). If it isn't valid for quartz, an error message should be shown.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Brydie McCoy [Atlassian] added a comment - 29/May/07 12:14 AM

Hi,

Thanks for pointing this out. I have added extra validation to catch out these errors when you are configuring the build rather than later down the track. The changes will be included in the next release.

Cheers,
Brydie