Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-3613

Unapprove reviewers hook should be an event listener

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • None
    • Pull Requests
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Forks have thrown a bit of a spanner in the works of the Unapprove Reviewers Hook doesn't make a lot of sense. Enabling it for a repository does not mean that updates to cross-repository pull requests will necessarily unapprove reviewers - it would need to be enabled on both the source & target repository for it to be guaranteed to work.

      I'm thinking this plugin should no longer be a hook. Instead it might be best re-implemented as an event listener (listening for the PullRequestRescopedEvent - https://developer.atlassian.com/static/javadoc/stash/2.5.0/api/reference/com/atlassian/stash/event/pull/PullRequestRescopedEvent.html) with a checkbox that can be toggled on and off per repository in the Pull Request settings page, rather than as a repository hook.

              Unassigned Unassigned
              tim@atlassian.com TimP
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: