Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-3463

Invalid "Authorization" headers for basic auth result in 500 errors

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 2.4.2
    • 2.3.0
    • None
    • None

      Parsing for the "Authorization" header is done outside the try/finally block, in StashAuthenticationFilter, but the code may throw a BadCredentialsException if the header is not valid. Since this is outside the exception handling, it results in a 500 error instead of a 401. This is particularly problematic for git hosting operations, which abort after a 500 instead of prompting for credentials like they would on a 401.

            [BSERV-3463] Invalid "Authorization" headers for basic auth result in 500 errors

            Owen made changes -
            Workflow Original: Stash Workflow - Restricted [ 1446383 ] New: JAC Bug Workflow v3 [ 3135375 ]
            Owen made changes -
            Workflow Original: Stash Workflow [ 531713 ] New: Stash Workflow - Restricted [ 1446383 ]
            Bryan Turner (Inactive) made changes -
            Fix Version/s New: 2.4.2 [ 32792 ]
            Resolution New: Fixed [ 1 ]
            Status Original: To be reviewed [ 10026 ] New: Closed [ 6 ]
            Bryan Turner (Inactive) made changes -
            Status Original: In Progress [ 3 ] New: To be reviewed [ 10026 ]
            Bryan Turner (Inactive) made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            Bryan Turner (Inactive) made changes -
            Status Original: Needs Triage [ 10030 ] New: Open [ 1 ]
            Bryan Turner (Inactive) created issue -

              bturner Bryan Turner (Inactive)
              bturner Bryan Turner (Inactive)
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: