Uploaded image for project: 'Sourcetree for Windows'
  1. Sourcetree for Windows
  2. SRCTREEWIN-4329

Pull from branch not defaulting to correct branch

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 2.5
    • 1.8.1, 1.8.3, 1.9.6, 2.0.20.1
    • Git
    • Severity 3 - Minor

      RIght click remote branch - "Pull xxx into current branch" the pull screen "Remote branch to pull" defaults to current branch rather than xxx

            [SRCTREEWIN-4329] Pull from branch not defaulting to correct branch

            Monique Khairuliana (Inactive) made changes -
            Workflow Original: JAC Bug Workflow v3 [ 3452851 ] New: SRCTREE JAC Bug Workflow [ 3742912 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: SourceTree Bug Workflow [ 1138610 ] New: JAC Bug Workflow v3 [ 3452851 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Dmytro Vasyliuk (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            liber-takano added a comment - - edited

            Is there an operation method to prevent this bug from occurring?

             

            maybe, use menu, not use pull button ?

            liber-takano added a comment - - edited Is there an operation method to prevent this bug from occurring?   maybe, use menu, not use pull button ?
            Mike Corsaro (Inactive) made changes -
            Status Original: Verified [ 10005 ] New: In Progress [ 3 ]

            Mike Corsaro (Inactive) added a comment -

            Hello! This issue will be fixed in the 2.5.x release.

            What caused this bug:

            • The pull dialog has 2 constructors: one that accepts an additional remote and branch parameter, and one that doesn't.
            • When the constructor is done, it kicks-off an async method that populates the remote and branch field so you don't have to type in that info
            • However, when the selected-remote is changed it also kicks off that same async method, which results in a race-condition that prevents the passed branch and remote from being used.

            The fix:

            • The constructor that didn't accept the optional branch and remote has been removed, so now there's only one constructor which prevents a second call to the async branch population method.

            Mike Corsaro (Inactive) added a comment - Hello! This issue will be fixed in the 2.5.x release. What caused this bug: The pull dialog has 2 constructors: one that accepts an additional remote and branch parameter, and one that doesn't. When the constructor is done, it kicks-off an async method that populates the remote and branch field so you don't have to type in that info However, when the selected-remote is changed it also kicks off that same async method, which results in a race-condition that prevents the passed branch and remote from being used. The fix: The constructor that didn't accept the optional branch and remote has been removed, so now there's only one constructor which prevents a second call to the async branch population method.
            Mike Corsaro (Inactive) made changes -
            Fix Version/s New: 2.5 [ 78192 ]

            psollberger added a comment - - edited

            As i can see this task was assigned and the priority raised. Finally! Thank you!

            But IMHO the priority is still not high enough.

            psollberger added a comment - - edited As i can see this task was assigned and the priority raised. Finally! Thank you! But IMHO the priority is still not high enough.
            Mike Corsaro (Inactive) made changes -
            Priority Original: Low [ 4 ] New: Medium [ 3 ]
            Mike Corsaro (Inactive) made changes -
            Assignee New: Mike Corsaro [ mcorsaro ]

              mcorsaro Mike Corsaro (Inactive)
              2302b1b4ec28 alan crocker
              Affected customers:
              20 This affects my team
              Watchers:
              22 Start watching this issue

                Created:
                Updated:
                Resolved: