Uploaded image for project: 'Confluence Source Editor Plugin'
  1. Confluence Source Editor Plugin
  2. SOURCE-62

Lines with 1 character prevent the source editor from opening.

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 1.0.2
    • 1.0
    • None

    • Confluence 4.2 on Tomcat, Windows Server 2008 R2, Java version 1.7.0

    • true

      I was able to open several of my pages in the new source editor, but I have one that always gives me error 500. It is an admin changelog that I maintain to keep track of what I've done with the confluence installation. It has a bunch of H1 headings, and several code block macros. Otherwise, it's just text.

        1. editor markup.txt
          4 kB
        2. thread dump.txt
          19 kB

            [SOURCE-62] Lines with 1 character prevent the source editor from opening.

            Petch (Inactive) made changes -
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Anatoli Kazatchkov [Administrative Account] made changes -
            Workflow Original: Confluence Bug Workflow [ 380216 ] New: New Confluence Default Workflow [ 466520 ]
            Petch (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Quality Review [ 10029 ] New: Resolved [ 5 ]
            Petch (Inactive) made changes -
            Status Original: Technical Review [ 10028 ] New: Quality Review [ 10029 ]
            Petch (Inactive) made changes -
            Fix Version/s New: 1.0.2 [ 26090 ]
            Petch (Inactive) made changes -
            Status Original: Open [ 1 ] New: Technical Review [ 10028 ]

            Petch (Inactive) added a comment - - edited

            Changed how indenting was performed to avoid error with short lines (and the potential to break CDATA / pre content).

            Also fixed issue with <br/> <hr/> being rendered as HTML tags (i.e. not self-closing).

            Petch (Inactive) added a comment - - edited Changed how indenting was performed to avoid error with short lines (and the potential to break CDATA / pre content). Also fixed issue with <br/> <hr/> being rendered as HTML tags (i.e. not self-closing).
            Petch (Inactive) made changes -
            Priority Original: Minor [ 4 ] New: Major [ 3 ]
            Summary Original: Most pages open fine in the new source editor, but one page gives an error 500 New: Lines with 1 character prevent the source editor from opening.

            Petch (Inactive) added a comment -

            There's a bug in the formatter, that for any line length 1 there's an array index error (it tries to read the 1st 2 characters but only does an empty line check).

            Will fix and release 1.0.2.

            Petch (Inactive) added a comment - There's a bug in the formatter, that for any line length 1 there's an array index error (it tries to read the 1st 2 characters but only does an empty line check). Will fix and release 1.0.2.

            Petch (Inactive) added a comment -

            Thanks Jason.

            Narrowed down further to the following markup:

            <p><br></p><table class="wysiwyg-macro" style="background-image: url(/plugins/servlet/confluence/placeholder/macro-heading?definition=e2NvZGU6dGl0bGU9Q3VzdG9tIEhUTUwgYXQgdGhlIGVuZCBvZiB0aGUgYm9keXxsYW5ndWFnZT1qYXZhc2NyaXB0fGNvbGxhcHNlPXRydWV9&amp;locale=en_GB&amp;version=2); background-repeat: no-repeat;" data-macro-name="code" data-macro-parameters="collapse=true|language=javascript|title=Custom HTML at the end of the body" data-macro-body-type="PLAIN_TEXT" data-mce-style="background-image: url('https://confxhtml.atlassian.com/plugins/servlet/confluence/placeholder/macro-heading?definition=e2NvZGU6dGl0bGU9Q3VzdG9tIEhUTUwgYXQgdGhlIGVuZCBvZiB0aGUgYm9keXxsYW5ndWFnZT1qYXZhc2NyaXB0fGNvbGxhcHNlPXRydWV9&amp;locale=en_GB&amp;version=2'); background-repeat: no-repeat;"><tbody><tr><td class="wysiwyg-macro-body"><pre> var CUSTOM_PLACEHOLDER = "Search Plasma-Therm";
 
 $searchBox = $("#quick-search-query");
</pre></td></tr></tbody></table><p><br></p>

            Petch (Inactive) added a comment - Thanks Jason. Narrowed down further to the following markup: <p><br></p><table class= "wysiwyg-macro" style= "background-image: url(/plugins/servlet/confluence/placeholder/macro-heading?definition=e2NvZGU6dGl0bGU9Q3VzdG9tIEhUTUwgYXQgdGhlIGVuZCBvZiB0aGUgYm9keXxsYW5ndWFnZT1qYXZhc2NyaXB0fGNvbGxhcHNlPXRydWV9&amp;locale=en_GB&amp;version=2); background-repeat: no-repeat;" data-macro-name= "code" data-macro-parameters= "collapse= true |language=javascript|title=Custom HTML at the end of the body" data-macro-body-type= "PLAIN_TEXT" data-mce-style= "background-image: url( 'https: //confxhtml.atlassian.com/plugins/servlet/confluence/placeholder/macro-heading?definition=e2NvZGU6dGl0bGU9Q3VzdG9tIEhUTUwgYXQgdGhlIGVuZCBvZiB0aGUgYm9keXxsYW5ndWFnZT1qYXZhc2NyaXB0fGNvbGxhcHNlPXRydWV9&amp;locale=en_GB&amp;version=2' ); background-repeat: no-repeat;" ><tbody><tr><td class= "wysiwyg-macro-body" ><pre> var CUSTOM_PLACEHOLDER = "Search Plasma-Therm" ; $searchBox = $( "#quick-search-query" ); </pre></td></tr></tbody></table><p><br></p>

              cpetchell Petch (Inactive)
              79e62be19901 Jason Plumhoff
              Archiver:
              mkhairuliana Monique Khairuliana (Inactive)

                Created:
                Updated:
                Resolved:
                Archived:
                13 years, 9 weeks, 6 days ago