Uploaded image for project: 'Server Deployments and Scale'
  1. Server Deployments and Scale
  2. SCALE-127

Introduce Tomcat internalProxies/trustedProxies and AccessLogValve's requestAttributesEnabled properties

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • None
    • None
    • Environment - Docker
    • None

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Looking to standardise the Load Balancer configuration on Atlassian Docker Images, I propose a change to configure the following Tomcat properties by using environment variables:

       

      Property Environment variable
      trustedProxies ATL_TOMCAT_TRUSTEDPROXIES
      internalProxies ATL_TOMCAT_INTERNALPROXIES
      requestAttributesEnabled ATL_TOMCAT_REQUESTATTRIBUTESENABLED

       

      Both trustedProxies and internalProxies require IP addresses with escaped dots, so ideally a new logic on entrypoint_helpers.py needs to parse the declared IP addresses for consistency.

      For requestAttributesEnabled, it can be assumed as false by default.

            [SCALE-127] Introduce Tomcat internalProxies/trustedProxies and AccessLogValve's requestAttributesEnabled properties

            Eduardo Alvarenga added a comment -

            c64f33b2bce3 achystoprudov long time now see!

            Can you please close this one? I have implemented it in https://bitbucket.org/atlassian-docker/docker-bamboo-server/pull-requests/67 long ago. Not sure why I forgot to close it, now I'm in a new job and found this one and got surprised it was still open Thanks!!!!

            Eduardo Alvarenga added a comment - c64f33b2bce3 achystoprudov long time now see! Can you please close this one? I have implemented it in https://bitbucket.org/atlassian-docker/docker-bamboo-server/pull-requests/67 long ago. Not sure why I forgot to close it, now I'm in a new job and found this one and got surprised it was still open Thanks!!!!
            Eduardo Alvarenga (Inactive) created issue -

              Unassigned Unassigned
              73868399605e Eduardo Alvarenga (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: