Uploaded image for project: 'Jira Software Data Center'
  1. Jira Software Data Center
  2. JSWSERVER-4358

GreenHopper doesn't set the encoding when using the maven-compiler-plugin

      The version of the maven-compiler-plugin GreenHopper uses (2.0.2) doesn't define a default encoding to use with the java compiler, and will therefore be using the platform default which can cause issues.

          Form Name

            [JSWSERVER-4358] GreenHopper doesn't set the encoding when using the maven-compiler-plugin

            You should be able to remove the encoding part of the configuration, but don't remove the plugin definition. I've checked and you guys are still on an old version of the parent (closed source) pom, version 25. You should probably consider updating to a later version, which would allow you to remove some cruft in your own poms. Note that updating might not be as trivial as one thinks...

            Samuel Le Berrigaud added a comment - You should be able to remove the encoding part of the configuration, but don't remove the plugin definition. I've checked and you guys are still on an old version of the parent (closed source) pom, version 25. You should probably consider updating to a later version, which would allow you to remove some cruft in your own poms. Note that updating might not be as trivial as one thinks...

            We still have this definition:

                            <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-compiler-plugin</artifactId>
                                <version>2.4</version>
                                <configuration>
                                    <source>1.6</source>
                                    <target>1.6</target>
                                    <encoding>${project.build.sourceEncoding}</encoding>
                                    <!-- this is the default in version 2.3.2 of the plugin, but for now we're using version 2.0.2 -->
                                    <maxmem>512m</maxmem>
                                </configuration>
                            </plugin>
            

            Should we just remove it?

            Michael Tokar added a comment - We still have this definition: <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-compiler-plugin</artifactId> <version>2.4</version> <configuration> <source>1.6</source> <target>1.6</target> <encoding>${project.build.sourceEncoding}</encoding> <!-- this is the default in version 2.3.2 of the plugin, but for now we're using version 2.0.2 --> <maxmem>512m</maxmem> </configuration> </plugin> Should we just remove it?

            mtokar this probably is not an issue anymore. Esp. that IIRC I already applied a fix. If you guys upgraded your parent POM "recently" and do not override the maven-compiler-plugin version then it should be all good.

            Samuel Le Berrigaud added a comment - mtokar this probably is not an issue anymore. Esp. that IIRC I already applied a fix. If you guys upgraded your parent POM "recently" and do not override the maven-compiler-plugin version then it should be all good.

            sleberrigaud do you think this is still an issue?

            Michael Tokar added a comment - sleberrigaud do you think this is still an issue?

            I've applied solution #2 mentioned in JRA-26744 for now.

            Samuel Le Berrigaud added a comment - I've applied solution #2 mentioned in JRA-26744 for now.

              Unassigned Unassigned
              sleberrigaud Samuel Le Berrigaud
              Affected customers:
              0 This affects my team
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: