Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-60530

Gadgets server-to-server connectivity errors are swallowed, we should log them instead

XMLWordPrintable

      NOTE: This bug report is for JIRA Server. Using JIRA Cloud? See the corresponding bug report.

      While working through JSP-261648 we noticed that certain gadget network connectivity problems when the server attempted to talk to itself/the proxy to download message bundles were being silently swallowed.

      We should probably log these at warning level instead so that support have info when a customer has these kinds of gadget issues.

      Source: com.atlassian.gadgets.renderer.internal.http.HttpClientFetcher.fetch(HttpRequest):

       } catch (IOException e) {
            if (e instanceof java.net.SocketTimeoutException || e instanceof java.net.SocketException) {
                return HttpResponse.timeout();
            } else {
                log.error("Unable to retrieve response", e);
            }
            return HttpResponse.error();
        }

      Fair enough for SocketTimeoutException (though still might be worth logging at DEBUG?) but SocketException subclasses (NoRouteToHostException for example) occurs for DNS lookup failure, network connectivity issues (e.g. when firewall prevents connecting to ourselves or a reverse proxy) and we should probably log those at WARN level.

      Might also want to change network connectivity issues to return HttpResponse.error() instead of timeout since those aren't really timeouts at all.

            [JRASERVER-60530] Gadgets server-to-server connectivity errors are swallowed, we should log them instead

            There are no comments yet on this issue.

              lwlodarczyk Lukasz Wlodarczyk
              prunge Peter Runge (Inactive)
              Affected customers:
              1 This affects my team
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: