Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-42996

Fix setupMode flag in upgrade tasks

XMLWordPrintable

    • 5
    • Severity 3 - Minor
    • Hide
      Atlassian Update – 28 May 2018

      Hi everyone,

      We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Time Out.

      Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details.

      We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication.
      Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

      Thank you,
      Ignat Alexeyenko
      Jira Bugmaster

      Show
      Atlassian Update – 28 May 2018 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Time Out . Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Thank you, Ignat Alexeyenko Jira Bugmaster

      doUpgrade method in UpgradeTask takes setupMode flag parameter. Most upgrade tasks that make use of it, assume that when it is true, the database is in the initial state, so upgrade does not have to be run. This is not correct, as during initial setup you can import data, and this flag is also set true. This flag should be renamed and should only be true if upgrade task is run against initial database.

      Setting as Critical because it is likely to cause data integrity issues if we continue treating this incorrectly. We've already run into this a few times and it's only luck which has meant a critical problem has not arisen.

            [JRASERVER-42996] Fix setupMode flag in upgrade tasks

            bain added a comment - - edited

            I had a quick look at this and made some notes that may be useful. Here are all the places the import is triggered:

            • UpgradeLauncher -> setupMode = false
            • SetupComplete -> setupMode = true (I am really not sure why it it called a second time)
            • InstantSetup -> setupMode = true (I am really not sure why it it called a second time)
            • DefaultImportService.performImport -> setupMode = DataImportParams.setupImport
              • DatabaseInitialImporter -> setupImport = true
              • EmbeddedDatabaseMigrator -> setupImport = true
              • DataImportAsyncCommand
                • SetupImport -> setupImport = true
                • ImportAll -> setupImport = false.

            bain added a comment - - edited I had a quick look at this and made some notes that may be useful. Here are all the places the import is triggered: UpgradeLauncher -> setupMode = false SetupComplete -> setupMode = true (I am really not sure why it it called a second time) InstantSetup -> setupMode = true (I am really not sure why it it called a second time) DefaultImportService.performImport -> setupMode = DataImportParams.setupImport DatabaseInitialImporter -> setupImport = true EmbeddedDatabaseMigrator -> setupImport = true DataImportAsyncCommand SetupImport -> setupImport = true ImportAll -> setupImport = false.

            Eric Dalgliesh added a comment -

            This was misfiled at https://jdog.jira-dev.com/browse/HIROL-745

            Eric Dalgliesh added a comment - This was misfiled at https://jdog.jira-dev.com/browse/HIROL-745

              Unassigned Unassigned
              edalgliesh Eric Dalgliesh
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: