Uploaded image for project: 'Jira Server and Data Center'
  1. Jira Server and Data Center
  2. JRASERVER-42438

UpgradeManager has a major liability in the way it instantiates classes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.10
    • Component/s: Upgrade
    • Labels:
      None

      Description

      NOTE: This bug report is for JIRA Server. Using JIRA Cloud? See the corresponding bug report.

      The code in UpgradeManager is broken. It silently ignores any upgrade task class that cannot be instantiated and moves on :

                  while (actions.hasMoreElements())
                  {
                      final Element action = (Element) actions.nextElement();
                      final String className = action.getElement("class").getTextString();
                      try
                      {
                          final UpgradeTask task = (UpgradeTask) JiraUtils.loadComponent(className, this.getClass());
      
                        .....
                          }
                      }
                      catch (final Exception e)
                      {
                          log.error("Exception loading type: " + className, e);
                      }
                  }
              }
      

      See the capture exception, log and move on. This THROWS the faulty upgrade task OUT Of the set, eg never puts in in there, and then the system will happily run all other stuff.

      This is a major liability to JIRA. Data upgrades are the "assurance" that your systems data is in a well known and consistent state.

      This issue is to capture JUST the changes need in UpgradeManagerImpl

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ohernandez@atlassian.com Oswaldo Hernandez (Inactive)
              Reporter:
              bbaker ɹǝʞɐq pɐɹq
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: