Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-32294

JIRA Suite Utilities causing Google Maps to load again if another plugin has already loaded it

    XMLWordPrintable

Details

    Description

      NOTE: This bug report is for JIRA Server. Using JIRA Cloud? See the corresponding bug report.

      Reproduction Steps
      Load / Refresh the view issue page for an issue on latest JIRA Master OnDemand

      What Happens

      • The following JS error is returned:
        TypeError: n.google.maps.Load is not a function
      • As a result, clicking on value for Location custom field doesn't show Google map

      Environment to reproduce problem

      • JIRA OnDemand version: ondemand-fireball-jira-master-1160
      • Browser and OS environments:
        Browser OS
        Firefox (19.0.2) Mac OS X (10.7.5)
        Safari 6.0.2 (7536.26.17) Mac OS X (10.7.5)
        Chrome 25.0.1364.172 Mac OS X (10.7.5)
        IE 8 (8.0.7601.17514) Windows 7 - Service Pack 1
        IE 9 (9.0.8112.16421) Windows 7 Professional - Service Pack 1
        IE 10 Windows 8 (version 6.2, build 9200)

      As Google Maps is being loaded on JIRA.Events.NEW_CONTENT_ADDED (which is now being fired multiple times per page), Google Maps is potentially being loaded twice by JIRA Suite Utilities, resulting in the JS error occurring and the inability to view Google maps of location fields.

      scinos, a JIRA developer, has listed the following for JIRA Suite Utilities to investigate in (as potential methods to rectify the issue). Please do not hesitate to mention or contact him if you have any questions regarding these:

      1. use a namespaced JSONP callback for loading Google Maps. Right now "onGMapsLoad" is being used and could conflict with other plugins
      2. check the "reason" parameter when listeing to JIRA.Events.NEW_CONTENT_ADDED. On KickAss we fire that event a few times per page and probably not all of them should trigger a Google Maps load
      3. Check that JIRA Suite Utilities is not trying to load google maps again if they have loaded it once but they are still waiting for the network
      4. update the code to use google.loader() instead loading gmaps directly

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              gwong GeoffreyA (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: