-
Bug
-
Resolution: Fixed
-
Medium (View bug fix roadmap)
-
5.1
-
None
-
5.01
-
To fix issues in inline edit for JIRA 5.1, the jira.webresources:viewissue resource was separated into:
- jira.webresources:viewissue-components, and
- jira.webresources:viewissue
viewissue-components is always pulled in, but viewissue is only pulled in if inline edit is disabled. This is an incorrect naming as https://developer.atlassian.com/display/JIRADEV/Loading+Issue+Tab+Panels+with+AJAX#LoadingIssueTabPanelswithAJAX-UsesofWebResourceManager.requireResource%28java.lang.String%29 tells plugin devs to explicitly pull in jira.webresources:viewissue.
Proposed solution:
- rename viewissue to viewissue-no-inlineedit (this only includes 2 resources that are overridden in kickass)
- rename viewissue-components to viewissue
- alias viewissue-components as viewissue (as it's been in released in 5.1 and at least one plugin has been fixed to reference viewissue-components)
- mentioned in
-
![[Atlassian Documentation] Page](/images/icons/generic_link_16.png "[Atlassian Documentation] Page")
Page
No Confluence page found with the given URL.
-
Page Loading...
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
![[Atlassian Documentation] Page](https://confluence.atlassian.com/images/icons/favicon.png "[Atlassian Documentation] Page"){kind=icon}
- relates to
-
| Form Name | |||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
[JRASERVER-28984] jira.webresources:viewissue incorrectly separated for JIRA 5.1
Draft: https://confluence.atlassian.com/display/JIRA/JIRA+5.1.1+Upgrade+Notes Will also need to be copied to 5.1.0 upgrade notes.
Tested with JIRA 5.1.2 BTF (https://jira.bamboo.atlassian.com/browse/BUGFIX51-QA-863)
Plugin versions tested with: DVCS Connector 0.3/1.0 and 1.0.1
Tested with - Inline Edit and without Inline Edit
Tested these operations:
1. Voters - ability to add, remove, view voters
2. Watchers - ability to watch, stop watch, view watchers
3. Different Issue Actions
Browsers tested across: IE8, IE9, FF14 and Chrome (20.x)
Yet to do: Test on OnDemand.
I believe this is affecting JAC now that it is running v5.1.1. Voters/watchers are semi-broken.
jcreenaune will document this here - https://developer.atlassian.com/display/JIRADEV/Preparing+for+JIRA+5.1.
In terms of the plugins JIRA bundles, this is not an issue with BTF but is an issue with OnDEmand. OnDemand will be resolved once 5.2-m01 is shipped.
I didn't realise that this meant reverting to the 5.0 API. In this case, let's do it ASAP.
Though lets make sure this is documented somewhere as it will catch quite a few devs.
This is because we don't want to change the front-end API in a point release.
I understand this, but I think there's more value in reverting to the 5.0 API (which should never have been broken) to enable 5.0 plugins to work without change; but still enabling anyone who's fixed their plugin for 5.1.0 / 5.1.1 to run against 5.1.2 / 5.2+
The correct API usage by version is:
5.0 - viewissue
5.1.0, 5.1.1 - viewissue-components because of the bug introduced by inline edit
5.1.2+, 5.2+ - can use viewissue or viewissue-components. things that explicitly shouldn't be used are viewissue-no-inlinedit
If we keep viewissue and viewissue-components as the same thing, plugins developed against all of those are the best going forward.
Tested this on JIRA OnDemand after KA Merge to master.
Fireball this was tested on: ondemand-fireball-jira-master-378
Tested on IE9.
This issue is fixed.