Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-27343

Issue summaries containing newlines produce corrupted "Share" emails

    XMLWordPrintable

Details

    Description

      When an issue summary contains a newline, the "Share" HTML email gets corrupted.

      Issue summaries don't normally have newlines as the standard JIRA UI doesn't allow it. However, they can be created by:
      1) Issues hanging around that were created in old versions of GreenHopper
      2) HTTP posts to CreateIssue.jspa
      3) Plugins
      4) Possibly REST?

      In this scenario, it was noticed using the Studio data populator.

      Repro steps (probably also reproable with direct DB hacking):
      1) Spin up an OnDemand instance.
      2) Run the Studio populator against it:
      https://sdog.jira.com/wiki/display/JST/Populating+Test+Data+into+a+Studio+Instance
      3) Set the current user's email format to HTML.
      4) Go to a populated issue and "share" it with the current user.
      5) Check your email.

      The email comes out corrupted due to a double-line-break in the middle of the email subject field.

      Delivered-To: pwyatt@atlassian.com
      Received: by 10.112.130.101 with SMTP id od5csp127100lbb;
              Thu, 16 Feb 2012 15:27:39 -0800 (PST)
      Received: by 10.68.193.232 with SMTP id hr8mr12852187pbc.158.1329434858670;
              Thu, 16 Feb 2012 15:27:38 -0800 (PST)
      Return-Path: <pwyatt@atlassian.com>
      Received: from psmtp.com ([74.125.149.122])
              by mx.google.com with SMTP id y4si5875817pbb.252.2012.02.16.15.27.35;
              Thu, 16 Feb 2012 15:27:38 -0800 (PST)
      Received-SPF: softfail (google.com: domain of transitioning pwyatt@atlassian.com does not designate 59.167.133.71 as permitted sender) client-ip=59.167.133.71;
      Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning pwyatt@atlassian.com does not designate 59.167.133.71 as permitted sender) smtp.mail=pwyatt@atlassian.com
      Received: from emx1-dev.syd-gs.atlassian.com ([59.167.133.71]) by na3sys009amx238.postini.com ([74.125.148.10]) with SMTP;
      	Thu, 16 Feb 2012 23:27:36 GMT
      Received: from localhost (zxu-12811.jira-dev.com.internal [10.64.8.240])
      	by emx1-dev.syd-gs.atlassian.com (Postfix) with ESMTP id 9C25E4100009
      	for <pwyatt@atlassian.com>; Fri, 17 Feb 2012 10:27:34 +1100 (EST)
      Date: Fri, 17 Feb 2012 10:27:32 +1100 (EST)
      From: "Administrator (JIRA)" <pwyatt@atlassian.com>
      To: pwyatt@atlassian.com
      Message-ID: <29039952.4.1329434854643.JavaMail.js-jira@zxu-12811.jira-dev.com>
      Subject: [JIRA] Administrator shared "PRJAVERW-31: Value is added twice to
       the Velocity context for Custom Fields
      
      " with you
      MIME-Version: 1.0
      Content-Type: text/html; charset=UTF-8
      Content-Transfer-Encoding: 7bit
      Precedence: bulk
      Auto-Submitted: auto-generated
      X-JIRA-FingerPrint: c1b88efd71e00b8beddc76ec962f937c
      
      
      
      
      
      
      
      
      
      
      
      
      
      
      
      
      
      
      <style>
      /* Changing the layout to use less space for mobiles */
      @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
          #email-body { min-width: 30em !important; }
          #email-page { padding: 8px !important; }
          #email-banner { padding: 8px 8px 0 8px !important; }
          #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
          #email-fields { padding: 0 8px 8px 8px !important; }
          #email-gutter { width: 0 !important; }
      }
      </style>
      <div id="email-body">
      <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
          <tr valign="top">
              <td id="email-page" style="padding:16px !important;">
                  <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                      <tr valign="top">
                          <td bgcolor="#003466" style="background-color:#003466;color:#fff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://zxu-12811.jira-dev.com/s/en_US84o85m/713/25/_/download/resources/com.atlassian.studio.static:studio_images/images/Atlassian.png" alt="" style="vertical-align:top;" /></td>
                      </tr><tr valign="top">
          <td id="email-banner" style="padding:32px 32px 0 32px;">
      
              
                  <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
          <tr valign="top">
              <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                              <img id="email-avatar" src="https://zxu-12811.jira-dev.com/secure/useravatar?avatarId=10122" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                              <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                          <a class="user-hover" rel="admin" id="email_admin" href="https://zxu-12811.jira-dev.com/secure/ViewProfile.jspa?name=admin" style="color:#326ca6;">Administrator</a>
           just shared <img src="https://zxu-12811.jira-dev.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://zxu-12811.jira-dev.com/browse/PRJAVERW-31'>PRJAVERW-31</a> with you
                  </div>
                              <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                      <a style="color:#326ca6;text-decoration:none;" href="https://zxu-12811.jira-dev.com/browse/PRJAVERW-31"><strong>Value is added twice to the Velocity context for Custom Fields
      </strong></a>
                  </div>
                          </td>
          </tr>
      </table>
      
          </td>
      </tr>
      <tr valign="top">
          <td id="email-fields" style="padding:0 32px 0 32px;">
              <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
                  <tr valign="top">
                      <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                      <td>
                          <table border="0" cellpadding="0" cellspacing="0" width="100%">
                              <tr valign="top">
          <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
              <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">This should be HTML
      </div>
              <div style="color:#505050;padding:4px 0 0 0;">                </div>
          </td>
      </tr>
                          </table>
                      </td>
                  </tr>
              </table>
          </td>
      </tr>
      <tr>
          <td style="padding:0 32px 32px 96px;">
              <a style='color:#326ca6;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12pxfont-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;text-decoration:none;' href='https://zxu-12811.jira-dev.com/browse/PRJAVERW-31'>View Issue</a> |
              <a style='color:#326ca6;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;text-decoration:none;' href='https://zxu-12811.jira-dev.com/browse/PRJAVERW-31#add-comment'>Add Comment</a>
          </td>
      </tr>
      
      
      
      
      
      
      
      
      
      
      
      
      
                  </table>
              </td><!-- End #email-page -->
          </tr>
          <tr valign="top">
              <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
                  This message is automatically generated by JIRA.<br />
                  If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='https://zxu-12811.jira-dev.com/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
                  For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
              </td>
          </tr>
      </table><!-- End #email-wrap -->
      </div><!-- End #email-body -->
      

      Attachments

        Issue Links

          Activity

            People

              rsmart metapoint
              pwyatt Penny Wyatt (On Leave to July 2021)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: