I was dealing with some Favicon code in Studio and after wondering why our logout page was not showing a favicon. As it turns out it is because the frontpage.jsp page does not include the favicons because they reside in header.jsp.

Either way, after talking to Dariusz, we thought it might be a good idea to refactor the favicons into their own include file, and include theme everywhere that they are required; like the frontpage.jsp and header.jsp.

This would really help with Studio because currently we patch frontpage.jsp with a made up favicon link that gets intercepted with every other favicon in our FaviconServlet and we would love to get rid of that little bit of indirection. The related studio bug is here: https://studio.atlassian.com/browse/JST-2955