Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-6687

Jira issue development panel shows wrong commits

    XMLWordPrintable

Details

    Description

      Summary

      A commit message containing a string similar to a JIRA issue will incorrectly link to the issue. Specifically, a commit message that resembles a JIRA issue key with spaces in it.

      Environment

      FishEye/Crucible 4.2.0

      Steps to Reproduce

      1. Create an application link between FishEye and JIRA
      2. Create a project called NS
      3. Create an issue
      4. Commit a change in the repo using git commit -m "test commit *** XX ns - 1 ns ***"
      5. In Jira development panel we will see the commit

      Expected Results

      This commit shouldn't be visible in JIRA issue

      Notes

      Found those entries referencing to the "ns - 2" commit message

      2016-10-18 16:19:56,825 DEBUG [qtp131872530-296 ] com.atlassian.fecru.plugin.jira.summary.service.DefaultCommitDetailsService DefaultCommitDetailsService-lambda$getCommitDetails$0 - Changeset query is +(comment:"ns - 2" -comment:"- ns - 2" p4.job:ns-2) +doctype:1
2016-10-18 16:19:56,830 DEBUG [qtp131872530-296 ] com.atlassian.fecru.plugin.jira.summary.service.DefaultCommitDetailsService DefaultCommitDetailsService-lambda$getCommitDetails$0 - Found 1 changeset docs in 1 repositories
2016-10-18 16:19:56,872 DEBUG [qtp131872530-296 ] fisheye RepositoryHandle-acquire - acquire engine on Hello, count=1, waited 0 ms to acquire.
2016-10-18 16:19:56,875 DEBUG [qtp131872530-296 ] fisheye RepositoryHandle-release - release engine on Hello, count=0 waited 0 ms to release
2016-10-18 16:19:56,877 DEBUG [qtp131872530-296 ] fisheye ProfilingServletFilter-logRequest - end request in 71ms GET /rest/dev-status/1.0/details/repositories?globalId=NS-2 nosession 200 mem=2.946MB
2016-10-18 16:19:57,108 DEBUG [Resource Monitor ] fisheye SystemResourceMonitor$MonitoringTask-run - tc=155, ofd=628, mfd=10240, fm=150547800, tm=541065216
2016-10-18 16:20:01,135 DEBUG [Resource Monitor ] fisheye SystemResourceMonitor$MonitoringTask-run - tc=154, ofd=628, mfd=10240, fm=150474760, tm=541065216
2016-10-18 16:20:03,020 DEBUG [notificationManager1 ] fisheye DefaultNotificationSender-lambda$sendNotifications$0 - Processing notifications

      2016-10-18 16:40:19,575 DEBUG [qtp131872530-317 ] com.atlassian.fecru.plugin.jira.summary.service.DefaultCommitDetailsService DefaultCommitDetailsService-lambda$getCommitDetails$0 - Changeset query is +(comment:"ns - 3" -comment:"- ns - 3" p4.job:ns-3) +doctype:1
2016-10-18 16:40:19,644 DEBUG [qtp131872530-317 ] com.atlassian.fecru.plugin.jira.summary.service.DefaultCommitDetailsService DefaultCommitDetailsService-lambda$getCommitDetails$0 - Found 1 changeset docs in 1 repositories
2016-10-18 16:40:19,681 DEBUG [qtp131872530-317 ] fisheye RepositoryHandle-acquire - acquire engine on Hello, count=2, waited 0 ms to acquire.
2016-10-18 16:40:19,722 DEBUG [IncrPing1 Hello ] fisheye DvcsProcessMonitor-onAfterFinished - Finished process: git show-ref --heads --no-abbrev took 545ms
2016-10-18 16:40:19,722 DEBUG [IncrPing1 Hello ] fisheye DvcsProcessMonitor-onBeforeStart - Starting process: git show-ref -d --tags
2016-10-18 16:40:19,731 DEBUG [qtp131872530-317 ] fisheye RepositoryHandle-release - release engine on Hello, count=1 waited 0 ms to release

      Attachments

        1. After_APP_link.png
          After_APP_link.png
          111 kB
        2. Before_APP_LINK.png
          Before_APP_LINK.png
          86 kB
        3. commit_linked_issue.png
          commit_linked_issue.png
          82 kB

        Issue Links

          incorporates

          Bug - A problem which impairs or prevents the functions of the product. CRUC-7247 Commit messages with an issue key preceded by a dash character are not visible in the JIRA development status panel.

          • Low - Low priority issues
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. FE-6558 Some FishEye commits missing in JIRA development panel

          • Low - Low priority issues
          • Long Term Backlog
          relates to

          Suggestion - FE-7150 Update Jira Issue project key formats to reflect Jira's more restrictive default

          • Not Being Considered

          Activity

            People

              Unassigned Unassigned
              dgnoato@atlassian.com Douglas Gnoato
              Votes:
              7 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated: