Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-6638

FishEye smart commit does not work with Chinese transition name from JIRA workflow

    XMLWordPrintable

Details

    Description

      Summary

      This is a follow up to FE-6201.

      According to this comment, the smart commit transition command is supposed to only work with the user's preferred language. For example, if JIRA language is set to Chinese language, users will need to use transition name in Chinese language in order for the smart commit to work. However, this does not work.

      It is likely that the regex to filter out the smart commit commands never worked for special characters in the first place, so any languages that use non-English characters will cause the smart commit to fail.

      Basically, when JIRA is set to a language other than English and that language has special characters (such as Chinese), BOTH English/Chinese smart commit messages will not work.

      Environment

      FishEye 3.9.0
      JIRA 7.1.9

      Steps to Reproduce

      1. Create an Application Links from JIRA to FishEye.
      2. Change to Chinese language via JIRA user profile/global configuration
      3. Create a new ticket from JIRA ie: TES-1
      4. Enable FishEye smart commits
      5. Add a commit message, ie: "TES-1 #完成 #COMMENT 026" (完成 = Done)
      6. The issue will not transition to 完成, but the comment will still be added to the ticket.

      Expected Results

      Issue should transition to 完成 and comment is added.

      Actual Results

      Issue does not transition to 完成, but the comment is added.

      Notes

      https://stash.atlassian.com/login?next=/projects/FECRU/repos/fecru/browse/src/bundled-plugins/bundled/commithooks/fecru-jiracommithook-plugin/src/main/java/com/atlassian/fecru/plugin/commithook/jira/commands/CommitCommentParser.java

      public static final Pattern COMMAND_PATTERN = Pattern.compile("#([A-Za-z][A-Za-z\\-]*)");

      This looks like it will only work for English characters? Either fix the regex, or give users an option to use English in smart commits regardless of what their preferred language is in JIRA.

      Workaround

      No workaround, unless JIRA admin manually removes the JIRA workflow transition translation from the language pack to allow users to commit in English.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              tchai Tzu Hau Chai (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: