Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-5799

Retrieving blame for Perforce repositories retrieves all the revisions in the files history

    XMLWordPrintable

Details

    Description

      This is mostly due to getFullFileHistory which eagerly loads all revisions, most of which are then discarded.

      Stack:

      "qtp1108066952-18022" #18022 prio=5 os_prio=0 tid=0x00007fd19800e800 nid=0x7807 waiting on condition [0x00007fde51b23000]
      ...
              at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.load(CommonRevInfoDAO.java:246)
              at com.cenqua.fisheye.perforce.db.P4RevInfoDAO.load(P4RevInfoDAO.java:186)
              at com.cenqua.fisheye.perforce.P4Cache.getFileHistory(P4Cache.java:261)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:203)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:240)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:240)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:240)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:240)
              at com.cenqua.fisheye.rep.SortedMapFileHistory.addFileAncestry(SortedMapFileHistory.java:240)
              at com.cenqua.fisheye.perforce.P4Cache.getFullFileHistory(P4Cache.java:274)
              at com.cenqua.fisheye.cache.BaseRevisionCache.getFullFileHistory(BaseRevisionCache.java:323)
              at com.cenqua.fisheye.perforce.P4Cache.getBlameFallback(P4Cache.java:314)
              at com.cenqua.fisheye.cache.BaseRevisionCache.getBlame(BaseRevisionCache.java:748)
              at com.cenqua.fisheye.rep.BaseLinecountCalculator.getHistory(BaseLinecountCalculator.java:210)
              at com.cenqua.fisheye.rep.BaseLinecountCalculator.getHistoryWithFallback(BaseLinecountCalculator.java:246)
              at com.cenqua.fisheye.web.tags.ExpressionUtil.getHistory(ExpressionUtil.java:89)
      

      Attachments

        Issue Links

          Activity

            People

              lpater Lukasz Pater
              lpater Lukasz Pater
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: