Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-5586

Watch Notification create review link incorrect when using context path

    XMLWordPrintable

Details

    Description

      Summary

      When using context path (eg: "/fecru"), the repository watch notification email "create a review" link use both value in "Site URL" (eg: http://localhost:8060/fecru) and context path to be an incorrect URL eg: http://localhost:8060/fecru//fecru/cru/create?csid=###

      Other links in watch notification is correct except for this "create a review" link

      Steps to Reproduce

      1. Set a Site URL including a context path (e.g. http://localhost:8060/fecru)
      2. Set a Web context (e.g. /fecru)
      3. Enable the Email notification
      4. Make a change for a repository you are watching

      Expected Results

      All the links in the received email are correct and point to a valid page for FishEye/Crucible.

      Actual Results

      The "create a review" link is incorrect and contains a duplicated context path:
      http://localhost:8060/fecru//fecru/cru/create?csid=<revision_id>

      Workaround

      The link can be changed by hardcoding the correct Site URL (including the context path) in the email template.

      1. Locate the <FishEye home directory>/fisheye/html/changeset-mail.ftl file
      2. Change this line (this is line 25 for version 3.8.1):
        [@a href="${siteurl}/${csd.createReviewUrl}"]create a review[/@a]
        

        To the following where <hardcoded_value> is the url of your instance. Note that there / should be removed.

        [@a href="<hardcoded_value>${csd.createReviewUrl}"]create a review[/@a]
        

      Attachments

        Issue Links

          Activity

            People

              pswiecicki Piotr Swiecicki
              klfoong Foong (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: