FishEye allows creation of repositories with duplicated names under race condition

DefaultRepositoryAdminService.create() lock configuration too late to prevent creation repositories with duplicated names. Steps to reproduce:

• insert a breakpoint in DefaultRepositoryAdminService.create() method somewhere between check if repo exists and creation of the repo. Ensure only current thread is stopped
• create 2 distinct repositories of the same name, stopping each thread on a breakpoint
• resume both threads
  Two repositories exists with same name and different definitions in config.xml. Repository admin shows only one of those repositories.

When fixing consider validating config.xml for duplicated repository names, log a warning perhaps or even drop duplicated repositories.

Safe steps to recover:

• identify repositories of duplicated names in config.xml
• rename/delete them to avoid name conflicts
• note this would trigger reindex, cross repository reindex may require reindexing too to remove old data
• authentication data may be lost, too