Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-5176

git rename detection breaks on files with non ASCII characters in their names

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Low
    • 3.4.1
    • 3.1.5, 3.2.0, 3.3.0, 3.4.0
    • None
    • None

    Description

      git diff command can quote one file name and leave another unquoted in its output in the diff --git line, see:

      $ git diff -C --no-abbrev --full-index -U0 b17f20aeb10f00d9b8c485b996d56470ebbc0948..ae1e8091e1ef8deab29731ebd4f7ba4ec0a536f3
      diff --git a/someFile.txt "b/anotherFile\n\r\t.txt"
      similarity index 100%
      rename from someFile.txt
      rename to "anotherFile\n\r\t.txt"
      

      on the https://bitbucket.org/pswiecicki/fe-5176-git-copy-detection-non-ascii-filenames git repository. Apparently GitDiffParser can't cope with it and throws StringIndexOutOfBoundException in such case.

      Workaround: switch off git rename detection for affected repository, i.e. change it to none and restart the repository.

      Attachments

        Issue Links

          Activity

            People

              pswiecicki Piotr Swiecicki
              pswiecicki Piotr Swiecicki
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: