Details
-
Bug
-
Resolution: Fixed
-
Medium
-
2.9.0
-
None
Description
DefaultChangesetCommentManager.getCommentsForRep() uses HibernateUtil.session() to access comments. This means that a threadlocal session is created on the indexing thread, which will never be closed. More-over, comments loaded into the session will remain in memory.
If for example a customer has 1000 repos, and each repo had 1000 changeset comments, at the end of a reindex of all 1000 repos, there will be 1,000,000 changeset comment objects held in the session associated with the indexing thread.
In addition, you'll get those "Waiting for session to close" messages on shutdown.
Attachments
Issue Links
- mentioned in
-
Page Loading...