Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-3608

Issue keys, wrapped in square brackets [JRA-9] are not linked correctly in quick search results

      If a commit message contains an issue key that is wrapped in square brackets, e.g: [JRA-9], the Commit Messages quick search results do not link the issue correctly.
      Instead of going to the http://jirahost/jira/browse/JRA-9, the link is simply relative to the FishEye instance. ie: http://fisheyehost/JRA-9 .

      This is most likely caused by a combination square brackets clashing with the wiki-rendering and also the hit-highlighting logic applied to search results.

      We need to investigate however this is not occurring on the changeset page in FishEye, just the search results.

            [FE-3608] Issue keys, wrapped in square brackets [JRA-9] are not linked correctly in quick search results

            @PIOTR: I am already in contact with your Support Team, they have all the juicy details. If this issue is not in all cases fixed in 3.6.1, then it might also not be fixed under certain circumstances in 3.6.2 and 3.7.0. If we can't get it fixed on our side, we will have to live with bug until we upgrade or remove the brackets from the commit Messages.

            Barbara Kohlroser added a comment - @PIOTR: I am already in contact with your Support Team, they have all the juicy details. If this issue is not in all cases fixed in 3.6.1, then it might also not be fixed under certain circumstances in 3.6.2 and 3.7.0. If we can't get it fixed on our side, we will have to live with bug until we upgrade or remove the brackets from the commit Messages.

            Piotr Swiecicki added a comment - - edited

            klb, I can't reproduce the problem on the recent (3.8 development) FeCru release, seems to be working fine. There was one issue touching this area fixed in 3.6.2 and 3.7.0 (FE-4719) but honestly I don't think it's related.
            If you still observe invalid behaviour please raise a separate bug report, providing as much details as possible - having full commit message would be great.
            Thanks,

            Piotr Swiecicki added a comment - - edited klb , I can't reproduce the problem on the recent (3.8 development) FeCru release, seems to be working fine. There was one issue touching this area fixed in 3.6.2 and 3.7.0 ( FE-4719 ) but honestly I don't think it's related. If you still observe invalid behaviour please raise a separate bug report, providing as much details as possible - having full commit message would be great. Thanks,

            Please re-open this bugfix-request. We are using FishEye 3.6.1 and JIRA Issues are not linked if in square brackets. Not only in search results, but everywhere in the application.

            Barbara Kohlroser added a comment - Please re-open this bugfix-request. We are using FishEye 3.6.1 and JIRA Issues are not linked if in square brackets. Not only in search results, but everywhere in the application.

            Chris Butler added a comment - - edited

            I'm not sure if it's the same issue or not, but we're having problems with a custom Linker when the value is inside square brackets. My linker regexp is "(?i)RT[\s#:]*(\d+)", and this works correctly - picking out the ticket number and linking to our RT system - unless the match is inside square brackets (e.g. "rt#1234"). With the brackets, I get a link relative to the current page (/graph/MODULE in this case).

            Note that I've turned off wiki syntax for commit messages, but it's still breaking...

            Edited to add: this is FishEye version 2.7.8.

            Chris Butler added a comment - - edited I'm not sure if it's the same issue or not, but we're having problems with a custom Linker when the value is inside square brackets. My linker regexp is "(?i)RT [\s#:] *(\d+)", and this works correctly - picking out the ticket number and linking to our RT system - unless the match is inside square brackets (e.g. " rt#1234 "). With the brackets, I get a link relative to the current page (/graph/MODULE in this case). Note that I've turned off wiki syntax for commit messages, but it's still breaking... Edited to add: this is FishEye version 2.7.8.

            AntonA added a comment -

            The complication to fixing this is added by the fact that hit highlighting in searching needs to be extended to support highlighting non-wiki highighted text.

            So when fixed we would check if the result comes from a repo that has wiki highlighting turned on or off and use the correct hit highlighting algorithm depending on the wiki render mode.

            AntonA added a comment - The complication to fixing this is added by the fact that hit highlighting in searching needs to be extended to support highlighting non-wiki highighted text. So when fixed we would check if the result comes from a repo that has wiki highlighting turned on or off and use the correct hit highlighting algorithm depending on the wiki render mode.

              bhumphreys BrendanA
              npellow Nick
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 0.1h
                  0.1h