Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-3478

Git diff processing fails for diffs with ^M characters in them

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 2.6.2
    • 2.5.6, 2.6.0
    • Indexing

    Description

      When a section in the output of git diff ... contains windows EOL characters, the GitDiffParser receives multiple lines for the single line of input. As a result the lines in the resulting Hunk instances will be inconsistent and bad things will happen (tm).

      Attached is a unit test and an example of diff output (from the jquery repo) that reproduces the error

      Attachments

        Activity

          People

            Unassigned Unassigned
            mheemskerk Michael Heemskerk (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: