Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-3151

Branch names with newlines break the HgChangeParser

    XMLWordPrintable

Details

    Description

      Summary

      In FishEye, if you have a branch in Mercurial containing a newline, indexing will fail.

      Steps to Reproduce

      1. Create a branch in hg with a newline.
         hg branch "Branch-1
        
        with some new lines"
      2. Output of hg felog:
        C:b4e08a48b5cb93d626f06915303dda6a677234e9
        R:1
        B:Branch-1
        
        with some new lines
        A:Andrew Myers <amyers@atlassian.com>
        D:1288652381.0-39600
        T:
        M:creating Branch-1
        P:74bacb671c151a27569debbca70765010fed53fd
        

      Expected Results

      Indexing completes successfully.

      Actual Results

      The below exception is thrown:

      Caused by: java.lang.RuntimeException: Match failed: string [], pattern [A:(.*)]
              at com.atlassian.fisheye.hg.client.HgChangeParser.doProcessLine(HgChangeParser.java:206)
              at com.atlassian.fisheye.dvcs.handler.DvcsLineOutputHandler.processLine(DvcsLineOutputHandler.java:19)
              at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:39)
              at com.atlassian.utils.process.PluggableProcessHandler.processOutput(PluggableProcessHandler.java:34)
              at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:186)
              ... 4 more
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              dlahn David Lahn (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: