SAL API packages not properly exported

I'm trying to get UPM working in Fisheye and running into some roadblocks. When starting up Fisheye 2.3.2 everything seemed to be going fine, but Fisheye appeared to "hang" on startup. It still appeared to be active, so there weren't any deadlocks. I then cranked up the debugging and found these messages when UPM is being enabled.

2010-06-10 11:04:36,104 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see javax.xml.bind.annotation from [0] and javax.xml.bind.annotation from [0]
2010-06-10 11:04:36,106 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see javax.xml.bind.annotation from [0] and javax.xml.bind.annotation from [0]
2010-06-10 11:04:36,108 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see javax.xml.bind.annotation from [0] and javax.xml.bind.annotation from [0]
2010-06-10 11:04:36,111 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see javax.xml.bind.annotation from [0] and javax.xml.bind.annotation from [0]
2010-06-10 11:04:36,113 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see com.atlassian.sal.api.message from [33.0] and com.atlassian.sal.api.message from [13.0]
2010-06-10 11:04:36,115 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see com.atlassian.sal.api.message from [33.0] and com.atlassian.sal.api.message from [13.0]
2010-06-10 11:04:36,117 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see com.atlassian.sal.api.message from [33.0] and com.atlassian.sal.api.message from [13.0]
2010-06-10 11:04:36,119 DEBUG [main] felix.FelixOsgiContainerManager FelixLoggerBridge-doLog - Constraint violation for 48.0 detected; module can see com.atlassian.sal.api.message from [33.0] and com.atlassian.sal.api.message from [13.0]

That repeats over and over in an infinite loop until Fisheye is killed.

I'm not sure wtf is going on with the javax.xml.bind.annotation violation. I do see in FisheyePluginManagerFactory that you export javax.* from the system classloader, but that should be fine afaik. Why it's complaining that it's finding the same package exported from the same bundle - the system bundle, in this case - I really don't understand. Unless that is conflicting with something hardcoded in the plugins system.

The second set of messages, about com.atlassian.sal.api.message being available from 2 bundles is more disturbing. I did some looking and the sal-api packages do, in fact, appear in 2 places in Fisheye: 1) the sal-api jar is a bundled plugin, and 2) the sal-api jar is bundled in the META-INF/lib directory of the sal-fisheye-plugin. The first packaging, as a bundled plugin, is correct. The second one will cause all kinds of problems as the implementation in the sal-fisheye-plugin will use it's internal packages. To avoid this problem, it appears the sal-fisheye-plugin also exports the sal-api packages, but it does this without any versioning. I think this is the cause of the problem that I am seeing.

I would recommend one of 2 approaches here: 1) Don't package the sal-api jar in the sal-fisheye-plugin, or 2) if you want to bundle the sal-api jar in the sal-fisheye-plugin to avoid the extra bundle, get rid of the sal-api jar as a bundled plugin and make sure to fix the sal-fisheye-plugin manifest to export the sal-api packages with proper versioning.