[JSWSERVER-14023] Pull request synchronization failed when connecting JIRA with MS SQL Server

Type: Bug
Resolution: Fixed
Priority: Highest (View bug fix roadmap)
Fix Version/s: None
Affects Version/s: DCON - old releases
Component/s: DVCS Accounts
Labels:
- migrated_from_dcon

Bug Fix Policy:
View Atlassian Server bug fix policy

NOTE: This bug report is for JIRA Software Server. Using JIRA Software Cloud? See the corresponding bug report.

On JIRA 6.2, connect with MS SQL Server 2008, when synchronizing a Bitbucket repository that contains pull requests, we see the following errors:

java.sql.SQLException: Incorrect syntax near the keyword 'COMMIT'.
	at com.atlassian.activeobjects.internal.EntityManagedActiveObjects.find(EntityManagedActiveObjects.java:179)
	at com.atlassian.activeobjects.osgi.DelegatingActiveObjects.find(DelegatingActiveObjects.java:93)
	at sun.reflect.GeneratedMethodAccessor316.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)
	at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.doInvoke(ServiceInvoker.java:58)
	at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.invoke(ServiceInvoker.java:62)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
	at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invokeUnprivileged(ServiceTCCLInterceptor.java:56)
	at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invoke(ServiceTCCLInterceptor.java:39)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.osgi.service.importer.support.LocalBundleContextAdvice.invoke(LocalBundleContextAdvice.java:59)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
	at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
	at com.sun.proxy.$Proxy2733.find(Unknown Source)
	at com.atlassian.jira.plugins.dvcs.dao.impl.RepositoryPullRequestDaoImpl.getCommitByNode(RepositoryPullRequestDaoImpl.java:337)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:384)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:374)
	at com.atlassian.jira.plugins.dvcs.sync.FlightTimeInterceptor.execute(FlightTimeInterceptor.java:25)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.loadPullRequestCommits(BitbucketSynchronizeActivityMessageConsumer.java:373)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.processActivity(BitbucketSynchronizeActivityMessageConsumer.java:185)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:125)
	at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:52)
	at com.atlassian.jira.plugins.dvcs.service.MessageExecutor$MessageRunnable.run(MessageExecutor.java:268)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:744)

The SQL in question is:

SELECT COMMIT.ID,COMMIT.* FROM dbo.AO_E8B6CC_COMMIT COMMIT JOIN dbo.AO_E8B6CC_PR_TO_COMMIT PR_TO_COMMIT ON COMMIT.ID = PR_TO_COMMIT.COMMIT_ID JOIN dbo.AO_E8B6CC_PULL_REQUEST PR ON PR_TO_COMMIT.REQUEST_ID = PR.ID WHERE COMMIT.DOMAIN_ID = ? AND PR.ID = ? AND COMMIT.NODE = ?

COMMIT is obviously a reserved keyword and MS SQL Server does not like it to be an alias.

Impacts

Pull requests are not synchronized.

Commits and branches are still synchronized.

relates to

JRACLOUD-86298 Pull request synchronization failed when connecting JIRA with MS SQL Server

Closed

clones: BBC-878 Failed to load

is caused by

AO-544 Escape table aliases in MS SQL Server

Done

Owen made changes - 16/Oct/2018 1:08 AM

Workflow	Original: JAC Bug Workflow v2 [ 2850826 ]	New: JAC Bug Workflow v3 [ 2936631 ]
Status	Original: Resolved [ 5 ]	New: Closed [ 6 ]

Owen made changes - 25/Sep/2018 12:47 AM

Workflow

Original: JIRA Bug Workflow w Kanban v7 - Restricted [ 2545590 ]

New: JAC Bug Workflow v2 [ 2850826 ]

Ignat (Inactive) made changes - 01/Feb/2018 12:08 PM

Workflow

Original: JIRA Bug Workflow w Kanban v6 - Restricted [ 1553425 ]

New: JIRA Bug Workflow w Kanban v7 - Restricted [ 2545590 ]

venugopal123 made changes - 31/Aug/2017 12:54 PM

Link

Original: This issue Discovered while testing ~~JSWSERVER-14175~~ [ ~~JSWSERVER-14175~~ ]

jonah (Inactive) made changes - 02/Apr/2017 12:00 PM

Description

Original: On JIRA 6.2, connect with MS SQL Server 2008, when synchronizing a Bitbucket repository that contains pull requests, we see the following errors:

{noformat}
java.sql.SQLException: Incorrect syntax near the keyword 'COMMIT'.
at com.atlassian.activeobjects.internal.EntityManagedActiveObjects.find(EntityManagedActiveObjects.java:179)
at com.atlassian.activeobjects.osgi.DelegatingActiveObjects.find(DelegatingActiveObjects.java:93)
at sun.reflect.GeneratedMethodAccessor316.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)
at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.doInvoke(ServiceInvoker.java:58)
at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.invoke(ServiceInvoker.java:62)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invokeUnprivileged(ServiceTCCLInterceptor.java:56)
at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invoke(ServiceTCCLInterceptor.java:39)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.osgi.service.importer.support.LocalBundleContextAdvice.invoke(LocalBundleContextAdvice.java:59)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy2733.find(Unknown Source)
at com.atlassian.jira.plugins.dvcs.dao.impl.RepositoryPullRequestDaoImpl.getCommitByNode(RepositoryPullRequestDaoImpl.java:337)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:384)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:374)
at com.atlassian.jira.plugins.dvcs.sync.FlightTimeInterceptor.execute(FlightTimeInterceptor.java:25)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.loadPullRequestCommits(BitbucketSynchronizeActivityMessageConsumer.java:373)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.processActivity(BitbucketSynchronizeActivityMessageConsumer.java:185)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:125)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:52)
at com.atlassian.jira.plugins.dvcs.service.MessageExecutor$MessageRunnable.run(MessageExecutor.java:268)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
{noformat}

The SQL in question is:
{code}
SELECT COMMIT.ID,COMMIT.* FROM dbo.AO_E8B6CC_COMMIT COMMIT JOIN dbo.AO_E8B6CC_PR_TO_COMMIT PR_TO_COMMIT ON COMMIT.ID = PR_TO_COMMIT.COMMIT_ID JOIN dbo.AO_E8B6CC_PULL_REQUEST PR ON PR_TO_COMMIT.REQUEST_ID = PR.ID WHERE COMMIT.DOMAIN_ID = ? AND PR.ID = ? AND COMMIT.NODE = ?
{code}

{{COMMIT}} is obviously a reserved keyword and MS SQL Server does not like it to be an alias.

h3. Impacts

Pull requests are not synchronized.

Commits and branches are still synchronized.

New: {panel:bgColor=#e7f4fa}
*NOTE:* This bug report is for *JIRA Software Server*. Using *JIRA Software Cloud*? [See the corresponding bug report|http://jira.atlassian.com/browse/JSWCLOUD-14023].
{panel}

On JIRA 6.2, connect with MS SQL Server 2008, when synchronizing a Bitbucket repository that contains pull requests, we see the following errors:

{noformat}
java.sql.SQLException: Incorrect syntax near the keyword 'COMMIT'.
at com.atlassian.activeobjects.internal.EntityManagedActiveObjects.find(EntityManagedActiveObjects.java:179)
at com.atlassian.activeobjects.osgi.DelegatingActiveObjects.find(DelegatingActiveObjects.java:93)
at sun.reflect.GeneratedMethodAccessor316.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)
at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.doInvoke(ServiceInvoker.java:58)
at org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.invoke(ServiceInvoker.java:62)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invokeUnprivileged(ServiceTCCLInterceptor.java:56)
at org.springframework.osgi.service.util.internal.aop.ServiceTCCLInterceptor.invoke(ServiceTCCLInterceptor.java:39)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.osgi.service.importer.support.LocalBundleContextAdvice.invoke(LocalBundleContextAdvice.java:59)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy2733.find(Unknown Source)
at com.atlassian.jira.plugins.dvcs.dao.impl.RepositoryPullRequestDaoImpl.getCommitByNode(RepositoryPullRequestDaoImpl.java:337)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:384)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer$4.call(BitbucketSynchronizeActivityMessageConsumer.java:374)
at com.atlassian.jira.plugins.dvcs.sync.FlightTimeInterceptor.execute(FlightTimeInterceptor.java:25)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.loadPullRequestCommits(BitbucketSynchronizeActivityMessageConsumer.java:373)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.processActivity(BitbucketSynchronizeActivityMessageConsumer.java:185)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:125)
at com.atlassian.jira.plugins.dvcs.sync.BitbucketSynchronizeActivityMessageConsumer.onReceive(BitbucketSynchronizeActivityMessageConsumer.java:52)
at com.atlassian.jira.plugins.dvcs.service.MessageExecutor$MessageRunnable.run(MessageExecutor.java:268)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
{noformat}

The SQL in question is:
{code}
SELECT COMMIT.ID,COMMIT.* FROM dbo.AO_E8B6CC_COMMIT COMMIT JOIN dbo.AO_E8B6CC_PR_TO_COMMIT PR_TO_COMMIT ON COMMIT.ID = PR_TO_COMMIT.COMMIT_ID JOIN dbo.AO_E8B6CC_PULL_REQUEST PR ON PR_TO_COMMIT.REQUEST_ID = PR.ID WHERE COMMIT.DOMAIN_ID = ? AND PR.ID = ? AND COMMIT.NODE = ?
{code}

{{COMMIT}} is obviously a reserved keyword and MS SQL Server does not like it to be an alias.

h3. Impacts

Pull requests are not synchronized.

Commits and branches are still synchronized.

jonah (Inactive) made changes - 02/Apr/2017 12:00 PM

Link

New: This issue relates to ~~JSWCLOUD-14023~~ [ ~~JSWCLOUD-14023~~ ]

Benjamin Morgan (Inactive) made changes - 14/Jul/2016 12:41 AM

Component/s		New: DVCS Accounts [ 43316 ]
Labels		New: migrated_from_dcon

Owen made changes - 12/Jul/2016 3:46 AM

Key	Original: ~~DCON-457~~	New: ~~JSW-14023~~
Affects Version/s		New: DCON - old releases [ 62520 ]
Affects Version/s	Original: 1.4.15 [ 38401 ]
Workflow	Original: classic workflow for JIRA DVCS Connector [ 721816 ]	New: JIRA Bug Workflow w Kanban v6 - Restricted [ 1553425 ]
Project	Original: DCON - deprecated use JSW [ 14710 ]	New: JIRA Software (including JIRA Agile) [ 12200 ]

ZehuaA made changes - 15/Aug/2014 5:47 AM

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

ZehuaA made changes - 14/Aug/2014 4:12 AM

Remote Link

New: This issue links to "AO-544 (Ecosystem JIRA)" [ 75001 ]

Assignee:: ZehuaA

Reporter:: ZehuaA

Affected customers:: 0 This affects my team

Watchers:: 1 Start watching this issue

Created:: 14/Aug/2014 4:04 AM

Updated:: 16/Oct/2018 1:08 AM

Resolved:: 15/Aug/2014 5:47 AM

Details

Description

Impacts

Attachments

Issue Links

Forms

Activity

People

Dates