Crowd removes the last occurrence of "/services" from the application URL

This causes JIRA to fail when connecting to crowd servers at URLs like:

• http://services-jira.atlassian.com/crowd
• http://mycrowd.atlassian.com/services-jira/crowd

See attached screenshot.

This is because we are trying to correct old URLs that contained services at the end of the path.

The first issue is that we should only remove this string from the path at the end of it, if it is present. We can use StringUtils.removeEnd to achieve this. The bug is at com.atlassian.crowd.service.client.ClientPropertiesImpl.generateBaseUrl line 140.

The second issue is that it's really questionable to do this sort of input validation in this layer of the code, this sort of validation should be done in consumers of this code (i.e. JIRA embedded crowd admin) as this is user input validation. In this layer if the url we should just assert on having a valid URL.