Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-2311

Crowd RemoteDirectory implementations should not throw RuntimeExceptions unless there is a catastrophic, system-wide, non-recoverable error

    XMLWordPrintable

Details

    Description

      Some examples include throwing IllegalArgumentExceptions and UnsupportedOperationExceptions

      Instead we should prefer throwing checked exceptions such as InvalidUser/InvalidGroup and ReadOnlyGroupException/OperationFailedException. The message of the method should be used to explain the underlying specific cause of the error as it is likely to get logged.

      Runtime exceptions cause the entire ASG iteration over directories to fail-fast and, in most cases, bubble straight up to the UI and smacks the user with a 500 page.

      Attachments

        Activity

          People

            4c7409f97ecf James Wong
            shamid@atlassian.com shihab
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 8h
                8h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 4h Time Not Required
                4h