Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-2193

Split out User Authorisation code from ApplicationService to a separate class

XMLWordPrintable

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      ApplicationService.isUserAuthorised(Application application, String username) checks if the user belongs to a authenticating group for the application. Extract this functionality from ApplicationService to a separate class/interface.

      Clean up includes removing the CachingApplicationService class, and providing a no-cache implementation of the user authorisation class for JIRA and Confluence to use.
      Change will break JIRA and Confluence when they upgrade to the next milestone.

        1. CWD-2193-a.patch
          100 kB

            [CWD-2193] Split out User Authorisation code from ApplicationService to a separate class

            AdrienA (Inactive) added a comment -

            Attached: CWD-2193-a.patch

            Contains:
            -Splitting UserAuthenticationService from ApplicationService.
            -Creating the Translatingxxx and Cachingxxx on the same model as ApplicationService.
            -Changing the Spring files to reflect this modification.

            Left to do:
            -Remove CachingApplicationService.
            -In ApplicationServiceTestCase and inheriting classes, the tests related to authentication and authorization should be moved to another test file inheriting from UserAuthenticationService.
            -TokenAuthenticationManagerImplTest is only testing authentication, so it doesn't need 'applicationService'. Does TokenAuthenticationManagerImpl need 'applicationService' then?
            -We need to check the change is ok for Confluence and Jira.

            AdrienA (Inactive) added a comment - Attached: CWD-2193 -a.patch Contains: -Splitting UserAuthenticationService from ApplicationService. -Creating the Translatingxxx and Cachingxxx on the same model as ApplicationService. -Changing the Spring files to reflect this modification. Left to do: -Remove CachingApplicationService. -In ApplicationServiceTestCase and inheriting classes, the tests related to authentication and authorization should be moved to another test file inheriting from UserAuthenticationService. -TokenAuthenticationManagerImplTest is only testing authentication, so it doesn't need 'applicationService'. Does TokenAuthenticationManagerImpl need 'applicationService' then? -We need to check the change is ok for Confluence and Jira.

              Unassigned Unassigned
              4c7409f97ecf James Wong
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:

                  Estimated:
                  Original Estimate - 8h
                  8h
                  Remaining:
                  Remaining Estimate - 8h
                  8h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified