Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-2189

Hibernate Backed Classes should not have immutable collections passed in

XMLWordPrintable

      We have an optimisation in our hibernate-backed Directory and Application code where instead of replacing the attributes, we update the existing collection (using retainAll). This assumes that the collection field is mutable. Since we can't just create a immutable copy of what's passed in setAttributes, we need to ensure that all usages of setAttributes are passing in an immutable copy.

            [CWD-2189] Hibernate Backed Classes should not have immutable collections passed in

            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 - restricted [ 1510659 ] New: JAC Bug Workflow v3 [ 3365214 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Owen made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 [ 1390662 ] New: Simplified Crowd Development Workflow v2 - restricted [ 1510659 ]
            Owen made changes -
            Workflow Original: Crowd Development Workflow v2 [ 275960 ] New: Simplified Crowd Development Workflow v2 [ 1390662 ]
            James Wong made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Technical Review [ 10028 ] New: Resolved [ 5 ]
            i made changes -
            Worklog Id Original: 94152 [ 94152 ]
            Time Spent Original: 8h [ 28800 ] New: 8.6h [ 30960 ]
            James Wong made changes -
            Worklog Id Original: 94121 [ 94121 ]
            Remaining Estimate Original: 2h [ 7200 ] New: 0h [ 0 ]
            Time Spent New: 8h [ 28800 ]
            James Wong made changes -
            Status Original: In Progress [ 3 ] New: Technical Review [ 10028 ]
            James Wong made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            James Wong made changes -
            Assignee New: James Wong [ 4c7409f97ecf ]
            James Wong made changes -
            Description Original: We have an optimisation in our hibernate-backed Directory and Application code where instead of replacing the attributes, we update the existing collection (using {{retainAll}}). This assumes that the collection field is mutable. New: We have an optimisation in our hibernate-backed Directory and Application code where instead of replacing the attributes, we update the existing collection (using {{retainAll}}). This assumes that the collection field is mutable. Since we can't just create a immutable copy of what's passed in {{setAttributes}}, we need to ensure that all usages of {{setAttributes}} are passing in an immutable copy.
            Summary Original: Hibernate Backed Classes should not immutable collections passed in New: Hibernate Backed Classes should not have immutable collections passed in
            James Wong created issue -

              4c7409f97ecf James Wong
              4c7409f97ecf James Wong
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - 2h Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 8.6h
                  8.6h