[CWD-1597] REST "directory" resource returns two levels of "<directories>" element

Type: Bug
Resolution: Fixed
Priority: High
Fix Version/s: 2.0
Affects Version/s: 2.0
Component/s: REST
Labels:
None
Environment:

Atlassian Crowd Version: 2.0-beta2 (Build:#401 - Jun 22, 2009)
Report a bug Request a feature Contact Atlassian

Bug Fix Policy:
View Atlassian Server bug fix policy

In the REST API, the URL below returns two levels of the <directories> element. Instead, the lower level should be <directory>:

URL:

http://localhost:8095/crowd/rest/admin/latest/directory

Returns something like this:

<?xml version="1.0" encoding="UTF-8" standalone="yes" ?> 
- <directories>
- <directories>
  <name>Active Directory</name> 
  <type>CONNECTOR</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.connector.MicrosoftActiveDirectory</implementationClass> 
  </directories>
- <directories>
  <name>Atlassian Crowd</name> 
  <type>INTERNAL</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.internal.InternalDirectory</implementationClass> 
  </directories>
- <directories>
  <name>Crowd Internal</name> 
  <type>INTERNAL</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.internal.InternalDirectory</implementationClass> 
  </directories>
- <directories>
  <name>Delegated Auth Directory</name> 
  <type>DELEGATING</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.delegated.DelegatedAuthenticationDirectory</implementationClass> 
  </directories>
- <directories>
  <name>Employees</name> 
  <type>INTERNAL</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.internal.InternalDirectory</implementationClass> 
  </directories>
- <directories>
  <name>My Own Connector</name> 
  <type>CUSTOM</type> 
  <implementationClass>com.atlassian.crowd.integration.directory.custom.MyOwnConnector</implementationClass> 
  </directories>
  </directories>

is incorporated by

CWD-1556 Review REST and finialise work

Closed

Justin Koke added a comment - 01/Jul/2009 3:20 AM

We now have the following data structures:
Users:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<users>
    <user>
        <identifier>admin</identifier>
        <username>admin</username>
        <firstName>Super</firstName>
        <lastName>User</lastName>
        <displayName>Super User</displayName>
        <emailAddress>admin@example.com</emailAddress>
    </user>
    <user>
        <identifier>joe</identifier>
        <username>joe</username>
        <firstName>Joe</firstName>
        <lastName>Small</lastName>
        <displayName>Joe Small</displayName>
        <emailAddress>joe@atlassian.com</emailAddress>
    </user>
</users>

Groups:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<groups>
    <group>
        <identifier>administrators</identifier>
        <name>administrators</name>
        <description>Generic Admin Role</description>
        <type>LEGACY_ROLE</type>
    </group>
    <group>
        <identifier>crowd-administrators</identifier>
        <name>crowd-administrators</name>
        <description/>
        <type>GROUP</type>
    </group>
    <group>
        <identifier>developers</identifier>
        <name>developers</name>
        <description>Generic Developer Role</description>
        <type>LEGACY_ROLE</type>
    </group>
    <group>
        <identifier>jira-administrators</identifier>
        <name>jira-administrators</name>
        <description>JIRA Admin Group</description>
        <type>GROUP</type>
    </group>
    <group>
        <identifier>jira-developers</identifier>
        <name>jira-developers</name>
        <description>JIRA Developer Group</description>
        <type>GROUP</type>
    </group>
</groups>

Directories:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<directories>
    <directory>
        <name>Second Directory</name>
        <type>INTERNAL</type>
        <implementationClass>com.atlassian.crowd.integration.directory.internal.InternalDirectory</implementationClass>
    </directory>
    <directory>
        <name>Test Internal Directory</name>
        <type>INTERNAL</type>
        <implementationClass>com.atlassian.crowd.integration.directory.internal.InternalDirectory</implementationClass>
    </directory>
</directories>

Justin Koke added a comment - 01/Jul/2009 3:20 AM We now have the following data structures: Users: <?xml version= "1.0" encoding= "UTF-8" standalone= "yes" ?> <users> <user> <identifier> admin </identifier> <username> admin </username> <firstName> Super </firstName> <lastName> User </lastName> <displayName> Super User </displayName> <emailAddress> admin@example.com </emailAddress> </user> <user> <identifier> joe </identifier> <username> joe </username> <firstName> Joe </firstName> <lastName> Small </lastName> <displayName> Joe Small </displayName> <emailAddress> joe@atlassian.com </emailAddress> </user> </users> Groups: <?xml version= "1.0" encoding= "UTF-8" standalone= "yes" ?> <groups> <group> <identifier> administrators </identifier> <name> administrators </name> <description> Generic Admin Role </description> <type> LEGACY_ROLE </type> </group> <group> <identifier> crowd-administrators </identifier> <name> crowd-administrators </name> <description/> <type> GROUP </type> </group> <group> <identifier> developers </identifier> <name> developers </name> <description> Generic Developer Role </description> <type> LEGACY_ROLE </type> </group> <group> <identifier> jira-administrators </identifier> <name> jira-administrators </name> <description> JIRA Admin Group </description> <type> GROUP </type> </group> <group> <identifier> jira-developers </identifier> <name> jira-developers </name> <description> JIRA Developer Group </description> <type> GROUP </type> </group> </groups> Directories: <?xml version= "1.0" encoding= "UTF-8" standalone= "yes" ?> <directories> <directory> <name> Second Directory </name> <type> INTERNAL </type> <implementationClass> com.atlassian.crowd.integration.directory.internal.InternalDirectory </implementationClass> </directory> <directory> <name> Test Internal Directory </name> <type> INTERNAL </type> <implementationClass> com.atlassian.crowd.integration.directory.internal.InternalDirectory </implementationClass> </directory> </directories>

SarahA added a comment - 01/Jul/2009 12:51 AM

Similarly, I'd expect a <groups> element and a <group> element in this response:

<restGroups>
  <groups>
  <identifier>my-team</identifier> 
  <name>my-team</name> 
  <description>My Team</description> 
  </groups>
</restGroups>

SarahA added a comment - 01/Jul/2009 12:51 AM Similarly, I'd expect a <groups> element and a <group> element in this response: <restGroups> <groups> <identifier> my-team </identifier> <name> my-team </name> <description> My Team </description> </groups> </restGroups>

SarahA added a comment - 30/Jun/2009 6:28 AM

Similarly, this URL returns two levels of <users> element:

http://localhost:8095/crowd/rest/admin/latest/directory/atlassian%20crowd/user?search=ad

Response:

 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?> 
<users>
 <users>
  <identifier>adent</identifier> 
  <username>adent</username> 
  <firstName>Arthur</firstName> 
  <lastName>Dent</lastName> 
  <displayName>Arthur Dent</displayName> 
  <emailAddress>adent@example.com</emailAddress> 
  </users>
 <users>
  <identifier>admin</identifier> 
  <username>admin</username> 
  <firstName>Admin</firstName> 
  <lastName>Administrator</lastName> 
  <displayName>Admin Administrator</displayName> 
  <emailAddress>smaddox@atlassian.com</emailAddress> 
  </users>
</users>

SarahA added a comment - 30/Jun/2009 6:28 AM Similarly, this URL returns two levels of <users> element: http://localhost:8095/crowd/rest/admin/latest/directory/atlassian%20crowd/user?search=ad Response: <?xml version= "1.0" encoding= "UTF-8" standalone= "yes" ?> <users> <users> <identifier> adent </identifier> <username> adent </username> <firstName> Arthur </firstName> <lastName> Dent </lastName> <displayName> Arthur Dent </displayName> <emailAddress> adent@example.com </emailAddress> </users> <users> <identifier> admin </identifier> <username> admin </username> <firstName> Admin </firstName> <lastName> Administrator </lastName> <displayName> Admin Administrator </displayName> <emailAddress> smaddox@atlassian.com </emailAddress> </users> </users>

Details

Description

Attachments

Issue Links

Forms

Activity

Collapse comment: Justin Koke added a comment - 01/Jul/2009 3:20 AM

Expand comment: Justin Koke added a comment - 01/Jul/2009 3:20 AM

Collapse comment: SarahA added a comment - 01/Jul/2009 12:51 AM

Expand comment: SarahA added a comment - 01/Jul/2009 12:51 AM

Collapse comment: SarahA added a comment - 30/Jun/2009 6:28 AM

Expand comment: SarahA added a comment - 30/Jun/2009 6:28 AM

People

Dates