Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-856

Improper handling of uploaded patch files with lines that have leading dashes

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 2.3.6
    • 1.6.3
    • None
    • None

    Description

      Crucible improperly processes patch files for diffs on files with leading dashes in their lines. This is really easy to reproduce with Lua files.

      I attached a rev-1 and rev-2 version of a demo Lua file. I also made a diff using "diff -Nar --unified=100 file-rev1.lua file-rev2.lua >lua-patch.txt" and attached that file as well.

      If you create a review in Crucible and upload lua-patch.txt you'll get a diff that stops at line 57 of the patch file. After that line of ------'s the remainder of the file that was added in rev 2 is invisible to Crucible.

      My guess is that it's a bug in processing of the — leader to separate files in patches. If I prefix all the comments in the file with a space before the – then Crucible processes the patch properly. I'm uploading lua-patch2.txt which shows this to be the case.

      Attachments

        1. file-rev1.lua
          2 kB
        2. file-rev2.lua
          2 kB
        3. lua-patch.txt
          3 kB
        4. lua-patch2.txt
          3 kB

        Activity

          People

            bhumphreys BrendanA
            46dd16050868 Scott Bilas
            Votes:
            6 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: