Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-7958

View dropdown not available for reviews based on pre-commit patches

    XMLWordPrintable

Details

    Description

      Summary

      The "View" dropdown is not available for any review based on pre-commit patches.

      Steps to Reproduce

      1. Create a review
      2. Add a pre-commit patch (git in the example below)

      Expected Results

      The "View" dropdown is available as in the previous versions of Crucible.

      The screenshots below have been generated with version 4.2.1.

      "View" dropdown with a review in Edit mode

      "View" dropdown with a review in non Edit mode

      Actual Results

      The "View" dropdown is not available.

      "View" dropdown missing with a review in Edit mode

      "View" dropdown missing with a review in non Edit mode

      Workaround

      The view defaults can be changed for each individual user profile by accessing the User Icon (in the top right corner of the screen) -> Profile settings and changing the Diff view -> Context lines option.
      Other options are available as well in the same dialog.

      Notes

      • The "View" dropdown is still present for other type of patches (non pre-commit).
      • The "View" dropdown is displayed for patches uploaded prior to the upgrade (e.g. created in 4.2.1).
      • The "View" dropdown is not displayed for patches uploaded after the upgrade to existing reviews (created prior to the upgrade)

      Attachments

        1. CRUC7958_421_EditMode.png
          CRUC7958_421_EditMode.png
          248 kB
        2. CRUC7958_421_NonEditMode.png
          CRUC7958_421_NonEditMode.png
          187 kB
        3. CRUC7958_430_EditMode.png
          CRUC7958_430_EditMode.png
          220 kB
        4. CRUC7958_430_NonEditMode.png
          CRUC7958_430_NonEditMode.png
          162 kB

        Issue Links

          Activity

            People

              mzyromski Mikolaj Zyromski
              ccurti Caterina Curti
              Votes:
              6 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: