Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-7196

crucible drops the rename in patch files

    XMLWordPrintable

Details

    Description

      When we add patches to crucible reviews that contain renames, like

      diff --git a/two b/three
      similarity index 64%
      rename from two
      rename to three
      index 75e1778..15815dd 100644
      --- a/two
      +++ b/three
      @@ -1,8 +1,8 @@
      -File two.
      +File three.
       This is a
       longer file
      

      we expect that crucible will display this as a rename, along with the file modifications. Full patch attached.

      However it instead shows this only as a modification of the file under the old name; the new name (`three`) doesn't show up anywhere in the review.

      We need to review such changes, and we need to do it via patches as crucible basically fails to index our repository, and thus commit-based reviews aren't feasible. Letting the patch describe the move as separate additions and removal makes crucible show it as such, but that doesn't help to actually review the content modifications.

      Attachments

        1. 00001-rename.patch
          0.6 kB
        2. copyfail.PNG
          copyfail.PNG
          29 kB
        3. crucfail2.png
          crucfail2.png
          52 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              1ccd56add922 Andreas Krey
              Votes:
              5 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: