Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6817

Abandoned reviews are included when applying a workflow transition for unreviewed changesets

XMLWordPrintable

      Not sure if this should be against JIRA or Crucible, as it relates to the integration between the two:
      JIRA Version: v6.2.1
      JIRA Fisheye plugin: v6.2.10

      I have a custom JIRA workflow which includes applying the following condition when transitioning to the Closed state:

      • This transition will only execute if there are no unreviewed changesets related to this issue

      If I have a changeset included in a review, but abandon that review, I can still transition the JIRA state to Closed, even though the commit shows no reviews in the Fisheye/Crucible Development tab.

      Deleting the review object removes the Close button, so it seems that Abandoned reviews are counted for changesets being reviewed, but not included when displaying reviews against a changeset.

      I feel like Abandoned reviews should be ignored completely with this check.

            [CRUC-6817] Abandoned reviews are included when applying a workflow transition for unreviewed changesets

            Joseph Marcel added a comment - - edited

            Agree w/ @Jacob Weber, these conditions are bypassed when the Crucible review is in 'Awaiting Approval' state as well... Can't help but wonder if the logic does a check specifically for Open like, "if relatedReview.status == Open" when it should check "if relatedReview.status not in (Closed, Abandoned)" ??

            Jira 8.10.0 and Crucible 4.8.3

            Joseph Marcel added a comment - - edited Agree w/ @Jacob Weber, these conditions are bypassed when the Crucible review is in 'Awaiting Approval' state as well... Can't help but wonder if the logic does a check specifically for Open like, "if relatedReview.status == Open" when it should check "if relatedReview.status not in (Closed, Abandoned)" ?? Jira 8.10.0 and Crucible 4.8.3

            Marek Parfianowicz added a comment -
            Atlassian Update – 5 October 2018

            Hi everyone,

            This issue has been reported several years ago for a version which is already end of life and is over 10 major releases behind the latest Fisheye/Crucible version. Additionally, it has not get interest since the time it has been reported. Therefore, we decided to close the issue as Timed Out.

            If you still see this bug occurring in the latest release and a fix is very important for you, please don't hesitate to share your feedback in the issue comments. We will continue to watch the issue for further updates.

            Cheers

            Marek Parfianowicz

            Fisheye/Crucible TL

            Marek Parfianowicz added a comment - Atlassian Update – 5 October 2018 Hi everyone, This issue has been reported several years ago for a version which is already end of life and is over 10 major releases behind the latest Fisheye/Crucible version. Additionally, it has not get interest since the time it has been reported. Therefore, we decided to close the issue as Timed Out . If you still see this bug occurring in the latest release and a fix is very important for you, please don't hesitate to share your feedback in the issue comments. We will continue to watch the issue for further updates. Cheers Marek Parfianowicz Fisheye/Crucible TL

            Jacob Weber added a comment -

            This is still an issue, and it's also the case with Draft reviews. So even if you have both conditions:

            • This transition will only execute if there are no unreviewed changesets related to this issue.
            • This transition will only execute if there are no Open Crucible reviews related to this issue

            you can bypass them both by opening a review in Draft mode for all the commits, or opening a review and abandoning it.

            I'm using Crucible 4.4.1 and Jira Server 7.4.1, but I don't see anything in the release notes for later versions that addresses this.

            Jacob Weber added a comment - This is still an issue, and it's also the case with Draft reviews. So even if you have both conditions: This transition will only execute if there are no unreviewed changesets related to this issue. This transition will only execute if there are no Open Crucible reviews related to this issue you can bypass them both by opening a review in Draft mode for all the commits, or opening a review and abandoning it. I'm using Crucible 4.4.1 and Jira Server 7.4.1, but I don't see anything in the release notes for later versions that addresses this.

              Unassigned Unassigned
              3ab372a716fc Nichaladas
              Affected customers:
              1 This affects my team
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: